From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C74C3C433E2 for ; Fri, 4 Sep 2020 14:18:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A272F2074D for ; Fri, 4 Sep 2020 14:18:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730474AbgIDOSW (ORCPT ); Fri, 4 Sep 2020 10:18:22 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:43134 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730675AbgIDORv (ORCPT ); Fri, 4 Sep 2020 10:17:51 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kECXA-00084r-J2; Sat, 05 Sep 2020 00:17:45 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sat, 05 Sep 2020 00:17:44 +1000 Date: Sat, 5 Sep 2020 00:17:44 +1000 From: Herbert Xu To: Srujana Challa Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-crypto@vger.kernel.org" , Suheil Chandran , Narayana Prasad Raju Athreya , Sunil Kovvuri Goutham , Linu Cherian , Geethasowjanya Akula , Jerin Jacob Kollanukkaran , Ard Biesheuvel Subject: Re: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine Message-ID: <20200904141744.GA3092@gondor.apana.org.au> References: <1596809360-12597-1-git-send-email-schalla@marvell.com> <1596809360-12597-3-git-send-email-schalla@marvell.com> <20200813005407.GB24593@gondor.apana.org.au> <20200904135044.GA2836@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Sep 04, 2020 at 02:14:34PM +0000, Srujana Challa wrote: > > Since LMT store is our platform specific, it cannot be generalized to all ARM64. I'm not asking you to generalise it to all of ARM64. I'm asking you to move this into a header file under arch/arm64 that can then be shared by both your crypto driver and your network driver so you don't duplicate this everywhere. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt