From: David Miller <davem@davemloft.net>
To: helmut.grohne@intenta.de
Cc: nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
ludovic.desroches@microchip.com, woojung.huh@microchip.com,
UNGLinuxDriver@microchip.com, andrew@lunn.ch,
vivien.didelot@gmail.com, f.fainelli@gmail.com, kuba@kernel.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: microchip: really look for phy-mode in port nodes
Date: Thu, 24 Sep 2020 20:10:14 -0700 (PDT) [thread overview]
Message-ID: <20200924.201014.1985667809546779432.davem@davemloft.net> (raw)
In-Reply-To: <20200924083746.GA9410@laureti-dev>
From: Helmut Grohne <helmut.grohne@intenta.de>
Date: Thu, 24 Sep 2020 10:37:47 +0200
> The previous implementation failed to account for the "ports" node. The
> actual port nodes are not child nodes of the switch node, but a "ports"
> node sits in between.
>
> Fixes: edecfa98f602 ("net: dsa: microchip: look for phy-mode in port nodes")
> Signed-off-by: Helmut Grohne <helmut.grohne@intenta.de>
Applied and queued up for -stable.
> I am very sorry that I need to send a fixup. It turned out that my
> testing methodology was flawed. When I reintegrated Linus' master
> branch, I noticed that it didn't work.
You should be testing against the 'net' GIT tree, not Linus's master
branch.
prev parent reply other threads:[~2020-09-25 3:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 8:22 net/dsa/microchip: correct placement of dt property phy-mode? Helmut Grohne
2020-06-17 21:18 ` Andrew Lunn
2020-07-14 12:08 ` [PATCH] net: dsa: microchip: look for phy-mode in port nodes Helmut Grohne
2020-07-14 22:27 ` Andrew Lunn
2020-07-15 7:31 ` Helmut Grohne
2020-07-15 13:00 ` Andrew Lunn
2020-07-16 7:00 ` Helmut Grohne
2020-07-16 10:07 ` Helmut Grohne
2020-08-20 6:03 ` [RESEND PATCH] " Helmut Grohne
2020-08-24 22:37 ` David Miller
2020-09-04 8:14 ` [PATCH v2] " Helmut Grohne
2020-09-04 12:59 ` Alexandre Belloni
2020-09-04 13:52 ` Andrew Lunn
2020-09-07 6:15 ` Helmut Grohne
2020-09-07 12:55 ` Andrew Lunn
2020-09-08 8:01 ` [PATCH v3] " Helmut Grohne
2020-09-10 19:32 ` David Miller
2020-09-24 8:37 ` [PATCH] net: dsa: microchip: really " Helmut Grohne
2020-09-25 3:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924.201014.1985667809546779432.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=helmut.grohne@intenta.de \
--cc=kuba@kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).