netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Geetha sowjanya <gakula@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<sgoutham@marvell.com>, <lcherian@marvell.com>,
	<jerinj@marvell.com>, <davem@davemloft.net>,
	Subbaraya Sundeep <sbhatta@marvell.com>
Subject: Re: [net PATCH] octeontx2-af: Fix enable/disable of default NPC entries
Date: Mon, 28 Sep 2020 14:28:37 -0700	[thread overview]
Message-ID: <20200928142837.0f529a24@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1601103420-1591-1-git-send-email-gakula@marvell.com>

On Sat, 26 Sep 2020 12:27:00 +0530 Geetha sowjanya wrote:
> From: Subbaraya Sundeep <sbhatta@marvell.com>
> 
> Packet replication feature present in Octeontx2
> is a hardware linked list of PF and its VF
> interfaces so that broadcast packets are sent
> to all interfaces present in the list. It is
> driver job to add and delete a PF/VF interface
> to/from the list when the interface is brought
> up and down. This patch fixes the
> npc_enadis_default_entries function to handle
> broadcast replication properly if packet replication
> feature is present.
> 
> Fixes: 40df309e4166
> ("octeontx2-af: Support to enable/disable default MCAM entries")
> 
> Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> Signed-off-by: Geetha sowjanya <gakula@marvell.com>
> Signed-off-by: Sunil Goutham <sgoutham@marvell.com>

The patches look good, but could you please resend them with fixed
"Fixes" tags? The tag should be on one line with no empty line between
the tag and the signoffs. So the above should have looked like:

Fixes: 40df309e4166 ("octeontx2-af: Support to enable/disable default MCAM entries")
Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
Signed-off-by: Geetha sowjanya <gakula@marvell.com>
Signed-off-by: Sunil Goutham <sgoutham@marvell.com>

      reply	other threads:[~2020-09-28 21:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-26  6:57 [net PATCH] octeontx2-af: Fix enable/disable of default NPC entries Geetha sowjanya
2020-09-28 21:28 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200928142837.0f529a24@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=gakula@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=lcherian@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).