From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
"David S . Miller" <davem@davemloft.net>,
Florian Westphal <fw@strlen.de>,
Peter Krystad <peter.krystad@linux.intel.com>,
netdev@vger.kernel.org, mptcp@lists.01.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it
Date: Tue, 20 Oct 2020 20:56:47 -0700 [thread overview]
Message-ID: <20201020205647.20ab7009@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <5dddd3fe-86d7-d07f-dbc9-51b89c7c8173@tessares.net>
On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote:
> On 20/10/2020 09:38, Geert Uytterhoeven wrote:
> > MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may
> > not want to enable. Fix this by making MPTCP_IPV6 depend on IPV6, like
> > is done for all other IPv6 features.
>
> Here again, the intension was to select IPv6 from MPTCP but I understand
> the issue: if we enable MPTCP, we will select IPV6 as well by default.
> Maybe not what we want on some embedded devices with very limited memory
> where IPV6 is already off. We should instead enable MPTCP_IPV6 only if
> IPV6=y. LGTM then!
>
> Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Applied, thanks!
next prev parent reply other threads:[~2020-10-21 3:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 7:38 [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it Geert Uytterhoeven
2020-10-20 9:26 ` Matthieu Baerts
2020-10-21 3:56 ` Jakub Kicinski [this message]
2020-10-21 9:43 ` Geert Uytterhoeven
2020-10-21 9:47 ` Matthieu Baerts
2020-10-21 9:52 ` Geert Uytterhoeven
2020-10-21 10:54 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020205647.20ab7009@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=peter.krystad@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).