From: Jason Gunthorpe <jgg@nvidia.com>
To: Maor Gottlieb <maorg@nvidia.com>
Cc: <linux-rdma@vger.kernel.org>,
Guoqing Jiang <guoqing.jiang@cloud.ionos.com>,
Christoph Hellwig <hch@lst.de>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
Leon Romanovsky <leonro@nvidia.com>,
Chao Leng <lengchao@huawei.com>,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
Keith Busch <kbusch@kernel.org>, <linux-nvme@lists.infradead.org>,
"Max Gurtovoy" <mgurtovoy@nvidia.com>, <netdev@vger.kernel.org>,
<rds-devel@oss.oracle.com>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH rdma v2] RDMA: Add rdma_connect_locked()
Date: Wed, 28 Oct 2020 09:14:37 -0300 [thread overview]
Message-ID: <20201028121437.GU1523783@nvidia.com> (raw)
In-Reply-To: <4401b7b1-5d05-a715-4701-957fd09f34c9@nvidia.com>
On Wed, Oct 28, 2020 at 11:19:14AM +0200, Maor Gottlieb wrote:
> > + struct rdma_conn_param *conn_param)
> > {
> > struct rdma_id_private *id_priv =
> > container_of(id, struct rdma_id_private, id);
> > int ret;
> > - mutex_lock(&id_priv->handler_mutex);
>
> You need to delete the mutex_unlock in success path too.
Gaaaaah. Just goes to prove I shouldn't write patches with a child on
my lap :\
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index f58d19881524dc..a77750b8954db0 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -4072,7 +4072,6 @@ int rdma_connect_locked(struct rdma_cm_id *id,
ret = -ENOSYS;
if (ret)
goto err_state;
- mutex_unlock(&id_priv->handler_mutex);
return 0;
err_state:
cma_comp_exch(id_priv, RDMA_CM_CONNECT, RDMA_CM_ROUTE_RESOLVED);
Thanks,
Jason
next prev parent reply other threads:[~2020-10-28 21:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 12:20 [PATCH rdma v2] RDMA: Add rdma_connect_locked() Jason Gunthorpe
2020-10-27 13:06 ` Max Gurtovoy
2020-10-27 13:19 ` Leon Romanovsky
2020-10-27 13:23 ` Jason Gunthorpe
2020-10-27 21:08 ` Sagi Grimberg
2020-10-28 9:19 ` Maor Gottlieb
2020-10-28 12:14 ` Jason Gunthorpe [this message]
2020-10-28 13:31 ` Maor Gottlieb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028121437.GU1523783@nvidia.com \
--to=jgg@nvidia.com \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=hch@lst.de \
--cc=jinpu.wang@cloud.ionos.com \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=leonro@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=mgurtovoy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=sagi@grimberg.me \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).