From: Vladimir Oltean <olteanv@gmail.com>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Hauke Mehrtens <hauke@hauke-m.de>,
Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Linus Walleij <linus.walleij@linaro.org>,
Vadym Kochan <vkochan@marvell.com>,
Taras Chornyi <tchornyi@marvell.com>,
Jiri Pirko <jiri@nvidia.com>, Ido Schimmel <idosch@nvidia.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Ivan Vecera <ivecera@redhat.com>
Subject: [PATCH v2 net-next 08/10] net: dsa: remove obsolete comments about switchdev transactions
Date: Wed, 6 Jan 2021 15:10:04 +0200 [thread overview]
Message-ID: <20210106131006.577312-9-olteanv@gmail.com> (raw)
In-Reply-To: <20210106131006.577312-1-olteanv@gmail.com>
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Now that all port object notifiers were converted to be non-transactional,
we can remove the comments that say otherwise.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Jiri Pirko <jiri@nvidia.com>
---
Changes in v2:
None.
net/dsa/slave.c | 5 -----
net/dsa/switch.c | 4 ----
2 files changed, 9 deletions(-)
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 4f0aae1192e5..963607547ab3 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -373,11 +373,6 @@ static int dsa_slave_port_obj_add(struct net_device *dev,
struct dsa_port *dp = dsa_slave_to_port(dev);
int err;
- /* For the prepare phase, ensure the full set of changes is feasable in
- * one go in order to signal a failure properly. If an operation is not
- * supported, return -EOPNOTSUPP.
- */
-
switch (obj->id) {
case SWITCHDEV_OBJ_ID_PORT_MDB:
if (obj->orig_dev != dev)
diff --git a/net/dsa/switch.c b/net/dsa/switch.c
index f92eaacb17cf..21d2f842d068 100644
--- a/net/dsa/switch.c
+++ b/net/dsa/switch.c
@@ -298,10 +298,6 @@ static int dsa_switch_event(struct notifier_block *nb,
break;
}
- /* Non-switchdev operations cannot be rolled back. If a DSA driver
- * returns an error during the chained call, switch chips may be in an
- * inconsistent state.
- */
if (err)
dev_dbg(ds->dev, "breaking chain for DSA event %lu (%d)\n",
event, err);
--
2.25.1
next prev parent reply other threads:[~2021-01-06 13:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 13:09 [PATCH v2 net-next 00/10] Get rid of the switchdev transactional model Vladimir Oltean
2021-01-06 13:09 ` [PATCH v2 net-next 01/10] net: switchdev: remove vid_begin -> vid_end range from VLAN objects Vladimir Oltean
2021-01-06 14:12 ` kernel test robot
2021-01-06 17:08 ` Vladimir Oltean
2021-01-06 17:08 ` Ido Schimmel
2021-01-06 17:15 ` Vladimir Oltean
2021-01-06 17:26 ` Ido Schimmel
2021-01-06 13:09 ` [PATCH v2 net-next 02/10] net: switchdev: remove the transaction structure from port object notifiers Vladimir Oltean
2021-01-06 17:42 ` Ido Schimmel
2021-01-06 13:09 ` [PATCH v2 net-next 03/10] net: switchdev: delete switchdev_port_obj_add_now Vladimir Oltean
2021-01-06 17:43 ` Ido Schimmel
2021-01-06 13:10 ` [PATCH v2 net-next 04/10] net: switchdev: remove the transaction structure from port attributes Vladimir Oltean
2021-01-06 17:47 ` Ido Schimmel
2021-01-06 13:10 ` [PATCH v2 net-next 05/10] net: dsa: remove the transactional logic from ageing time notifiers Vladimir Oltean
2021-01-06 13:10 ` [PATCH v2 net-next 06/10] net: dsa: remove the transactional logic from MDB entries Vladimir Oltean
2021-01-06 13:10 ` [PATCH v2 net-next 07/10] net: dsa: remove the transactional logic from VLAN objects Vladimir Oltean
2021-01-06 13:10 ` Vladimir Oltean [this message]
2021-01-06 13:10 ` [PATCH v2 net-next 09/10] mlxsw: spectrum_switchdev: remove transactional logic for " Vladimir Oltean
2021-01-06 18:10 ` Ido Schimmel
2021-01-06 13:10 ` [PATCH v2 net-next 10/10] net: switchdev: delete the transaction object Vladimir Oltean
2021-01-06 18:11 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106131006.577312-9-olteanv@gmail.com \
--to=olteanv@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=hauke@hauke-m.de \
--cc=idosch@nvidia.com \
--cc=ioana.ciornei@nxp.com \
--cc=ivecera@redhat.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
--cc=tchornyi@marvell.com \
--cc=vivien.didelot@gmail.com \
--cc=vkochan@marvell.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).