From: "Marek Behún" <kabel@kernel.org>
To: netdev@vger.kernel.org
Cc: "Russell King" <rmk+kernel@armlinux.org.uk>,
"Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
davem@davemloft.net, pali@kernel.org,
"Marek Behún" <kabel@kernel.org>
Subject: [PATCH net-next v4 0/4] Support for RollBall 10G copper SFP modules
Date: Mon, 11 Jan 2021 06:00:40 +0100 [thread overview]
Message-ID: <20210111050044.22002-1-kabel@kernel.org> (raw)
Hello,
this is v4 of series adding support for RollBall/Hilink SFP modules.
Checked with:
checkpatch.pl --max-line-length=80
Changes from v3:
- RollBall mdio-i2c driver now sets/restores SFP_PAGE for every MDIO
access.
I first wanted to achieve this operation (setting
SFP_PAGE/doing MDIO/restoring SFP_PAGE) via one call do i2c_transfer,
by constructing msgs array in such a way, but it turned out that this
doesn't work on RollBall SFPs, because changed SFP_PAGE takes into
account only after i2c_transfer ends.
So instead I use i2c_lock_bus/serveral __i2c_transfers/i2c_unlock_bus.
- I have removed the patch which changes MACTYPE in the marvell10g
driver, since Russell has in his net-queue a better solution. I still
think that my patch would have sufficed temporarily (and would not
cause regressions), but nobody wanted to review it. If you think that
I should sent this series again with that patch, please let me know.
Changes from v2:
- added comment into the patch adding support for RollBall I2C MDIO
protocol, saying that we expect the SFP_PAGE not to be changed by
the SFP code, as requested by Russell. If, in the future, SFP code
starts modifying SFP_PAGE, we will have to handle it in mdio-i2c
somehow
- destruction of I2C MDIO bus in patch 3/5 now depends on whether the
MDIO bus is not NULL, instead of whether PHY exists, as suggested by
Russell
- changed waiting time for RollBall module to initialize from 30 seconds
to 25 seconds. Testing shows that it is never longer than 21-22
seconds, so waiting 25 seconds instead of 30 is IMO safe enough
- added Russell's Reviewed-by tags where relevant
Changes from v1:
- wrapped to 80 columns as per Russell's request
- initialization of RollBall MDIO I2C protocol moved from sfp.c to
mdio-i2c.c as per Russell's request
- second patch removes the 802.3z check also from phylink_sfp_config
as suggested by Russell
- creation/destruction of mdiobus for SFP now occurs before probing
for PHY/after releasing PHY (as suggested by Russell)
- the last patch became a little simpler after the above was done
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Russell King <rmk+kernel@armlinux.org.uk>
Marek Behún (4):
net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules
net: phylink: allow attaching phy for SFP modules on 802.3z mode
net: sfp: create/destroy I2C mdiobus before PHY probe/after PHY
release
net: sfp: add support for multigig RollBall transceivers
drivers/net/mdio/mdio-i2c.c | 319 +++++++++++++++++++++++++++++++++-
drivers/net/phy/phylink.c | 5 +-
drivers/net/phy/sfp.c | 66 +++++--
include/linux/mdio/mdio-i2c.h | 8 +-
4 files changed, 378 insertions(+), 20 deletions(-)
base-commit: 73b7a6047971aa6ce4a70fc4901964d14f077171
--
2.26.2
next reply other threads:[~2021-01-11 5:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 5:00 Marek Behún [this message]
2021-01-11 5:00 ` [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules Marek Behún
2021-01-12 8:42 ` Heiner Kallweit
2021-01-12 14:02 ` Andrew Lunn
2021-01-12 14:40 ` Heiner Kallweit
2021-01-12 17:49 ` Marek Behún
2021-01-12 19:22 ` Russell King - ARM Linux admin
2021-01-18 12:13 ` Pali Rohár
2021-01-18 15:45 ` Russell King - ARM Linux admin
2021-01-12 20:20 ` Andrew Lunn
2021-01-12 20:43 ` Andrew Lunn
2021-01-12 20:53 ` Marek Behún
2021-01-12 20:55 ` Andrew Lunn
2021-01-12 20:54 ` Andrew Lunn
2021-01-12 21:01 ` Marek Behún
2021-01-13 10:51 ` Pali Rohár
2021-01-12 21:22 ` Russell King - ARM Linux admin
2021-01-13 11:22 ` Pali Rohár
2021-01-13 13:56 ` Andrew Lunn
2021-01-13 13:58 ` Pali Rohár
2021-01-13 16:14 ` Russell King - ARM Linux admin
2021-01-11 5:00 ` [PATCH net-next v4 2/4] net: phylink: allow attaching phy for SFP modules on 802.3z mode Marek Behún
2021-01-13 10:38 ` Pali Rohár
2021-01-11 5:00 ` [PATCH net-next v4 3/4] net: sfp: create/destroy I2C mdiobus before PHY probe/after PHY release Marek Behún
2021-01-13 10:41 ` Pali Rohár
2021-01-11 5:00 ` [PATCH net-next v4 4/4] net: sfp: add support for multigig RollBall transceivers Marek Behún
2021-01-13 10:49 ` Pali Rohár
2021-01-13 11:08 ` Russell King - ARM Linux admin
2021-01-13 11:26 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111050044.22002-1-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).