From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, alexandre.belloni@bootlin.com,
andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com,
alexandru.marginean@nxp.com, claudiu.manoil@nxp.com,
xiaoliang.yang_1@nxp.com, hongbo.wang@nxp.com, jiri@resnulli.us,
idosch@idosch.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v4 net-next 08/10] net: mscc: ocelot: register devlink ports
Date: Thu, 14 Jan 2021 09:19:43 -0800 [thread overview]
Message-ID: <20210114091943.3236215f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210114102743.etmvn7jq5jcgiqxk@skbuf>
On Thu, 14 Jan 2021 12:27:43 +0200 Vladimir Oltean wrote:
> On Wed, Jan 13, 2021 at 07:30:33PM -0800, Jakub Kicinski wrote:
> > On Mon, 11 Jan 2021 19:43:14 +0200 Vladimir Oltean wrote:
> > > +struct ocelot_devlink_private {
> > > + struct ocelot *ocelot;
> > > +};
> >
> > I don't think you ever explained to me why you don't put struct ocelot
> > in the priv.
> >
> > - ocelot = devm_kzalloc(&pdev->dev, sizeof(*ocelot), GFP_KERNEL);
> > - if (!ocelot)
> > + devlink = devlink_alloc(&ocelot_devlink_ops, sizeof(*ocelot));
> > + if (!devlink)
> > return -ENOMEM;
> > + ocelot = devlink_priv(ocelot->devlink);
>
> Because that's not going to be all? The error path handling and teardown
> all need to change, because I no longer use device-managed allocation,
> and I wanted to avoid that.
Come on, is it really hard enough to warrant us exchanging multiple
emails? Having driver structure in devlink priv is the standard way
of handling this, there's value in uniformity.
next prev parent reply other threads:[~2021-01-14 17:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 17:43 [PATCH v4 net-next 00/10] Configuring congestion watermarks on ocelot switch using devlink-sb Vladimir Oltean
2021-01-11 17:43 ` [PATCH v4 net-next 01/10] net: mscc: ocelot: auto-detect packet buffer size and number of frame references Vladimir Oltean
2021-01-11 17:43 ` [PATCH v4 net-next 02/10] net: mscc: ocelot: add ops for decoding watermark threshold and occupancy Vladimir Oltean
2021-01-11 17:43 ` [PATCH v4 net-next 03/10] net: dsa: add ops for devlink-sb Vladimir Oltean
2021-01-11 17:43 ` [PATCH v4 net-next 04/10] net: dsa: felix: reindent struct dsa_switch_ops Vladimir Oltean
2021-01-11 17:43 ` [PATCH v4 net-next 05/10] net: dsa: felix: perform teardown in reverse order of setup Vladimir Oltean
2021-01-11 17:43 ` [PATCH v4 net-next 06/10] net: mscc: ocelot: export NUM_TC constant from felix to common switch lib Vladimir Oltean
2021-01-11 17:43 ` [PATCH v4 net-next 07/10] net: mscc: ocelot: delete unused ocelot_set_cpu_port prototype Vladimir Oltean
2021-01-11 17:43 ` [PATCH v4 net-next 08/10] net: mscc: ocelot: register devlink ports Vladimir Oltean
2021-01-14 3:30 ` Jakub Kicinski
2021-01-14 10:27 ` Vladimir Oltean
2021-01-14 17:19 ` Jakub Kicinski [this message]
2021-01-14 17:25 ` Vladimir Oltean
2021-01-11 17:43 ` [PATCH v4 net-next 09/10] net: mscc: ocelot: initialize watermarks to sane defaults Vladimir Oltean
2021-01-11 17:43 ` [PATCH v4 net-next 10/10] net: mscc: ocelot: configure watermarks using devlink-sb Vladimir Oltean
2021-01-14 3:25 ` [PATCH v4 net-next 00/10] Configuring congestion watermarks on ocelot switch " Jakub Kicinski
2021-01-14 8:48 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114091943.3236215f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru.marginean@nxp.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hongbo.wang@nxp.com \
--cc=idosch@idosch.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).