From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Jiri Benc" <jbenc@redhat.com>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Eelco Chaudron" <echaudro@redhat.com>,
ast@kernel.org, "Daniel Borkmann" <daniel@iogearbox.net>,
"Lorenzo Bianconi" <lorenzo.bianconi@redhat.com>,
"David Ahern" <dsahern@gmail.com>,
"Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
"Alexei Starovoitov" <alexei.starovoitov@gmail.com>,
"John Fastabend" <john.fastabend@gmail.com>
Subject: Re: [PATCHv15 bpf-next 1/6] bpf: run devmap xdp_prog on flush instead of bulk enqueue
Date: Thu, 21 Jan 2021 14:35:38 +0100 [thread overview]
Message-ID: <20210121133538.GA41935@ranger.igk.intel.com> (raw)
In-Reply-To: <20210121035424.GK1421720@Leo-laptop-t470s>
On Thu, Jan 21, 2021 at 11:54:24AM +0800, Hangbin Liu wrote:
> Hi Maciej,
> On Wed, Jan 20, 2021 at 11:42:38PM +0100, Maciej Fijalkowski wrote:
> > > +static int dev_map_bpf_prog_run(struct bpf_prog *xdp_prog,
> > > + struct xdp_frame **frames, int n,
> > > + struct net_device *dev)
> > > +{
> > > + struct xdp_txq_info txq = { .dev = dev };
> > > + struct xdp_buff xdp;
> > > + int i, nframes = 0;
> > > +
> > > + for (i = 0; i < n; i++) {
> > > + struct xdp_frame *xdpf = frames[i];
> > > + u32 act;
> > > + int err;
> > > +
> > > + xdp_convert_frame_to_buff(xdpf, &xdp);
> > > + xdp.txq = &txq;
> > > +
> > > + act = bpf_prog_run_xdp(xdp_prog, &xdp);
> > > + switch (act) {
> > > + case XDP_PASS:
> > > + err = xdp_update_frame_from_buff(&xdp, xdpf);
> >
> > Bump on John's question.
>
> Hi Jesper, would you please help answer John's question?
> > >
> > > - sent = dev->netdev_ops->ndo_xdp_xmit(dev, bq->count, bq->q, flags);
> > > + /* Init sent to cnt in case there is no xdp_prog */
> > > + sent = cnt;
> > > + if (bq->xdp_prog) {
> > > + sent = dev_map_bpf_prog_run(bq->xdp_prog, bq->q, cnt, dev);
> > > + if (!sent)
> > > + goto out;
> >
> > Sorry, but 'sent' is a bit confusing to me, actual sending happens below
> > via ndo_xdp_xmit, right? This hook will not actually send frames.
> > Can we do a subtle change to have it in separate variable 'to_send' ?
>
> Makes sense to me.
> >
> > Although I'm a huge goto advocate, I feel like this particular usage could
> > be simplified. Not sure why we had that in first place.
> >
> > I gave a shot at rewriting/refactoring whole bq_xmit_all and I feel like
> > it's more readable. I introduced 'to_send' variable and got rid of 'error'
> > label.
> >
> > Thoughts?
> >
> > I might have missed something, though.
> >
> > static void bq_xmit_all(struct xdp_dev_bulk_queue *bq, u32 flags)
> > {
> > struct net_device *dev = bq->dev;
> > unsigned int cnt = bq->count;
> > int drops = 0, err = 0;
> > int to_send = 0;
>
> The to_send also need to init to cnt.
So I missed something indeed :P you're correct
>
> > int sent = cnt;
> > int i;
> >
> > if (unlikely(!cnt))
> > return;
> >
> > for (i = 0; i < cnt; i++) {
> > struct xdp_frame *xdpf = bq->q[i];
> >
> > prefetch(xdpf);
> > }
> >
> > if (bq->xdp_prog) {
> > to_send = dev_map_bpf_prog_run(bq->xdp_prog, bq->q, cnt, dev);
> > if (!to_send) {
> > sent = 0;
> > goto out;
> > }
> > }
> >
> > drops = cnt - to_send;
>
> This line could move in to the xdp_prog brackets to save time when no xdp_prog.
Hmm, looks like we can do it.
For scenario where there was no bq->xdp_prog and failure of ndo_xdp_xmit,
we didn't alter the count of frames to be sent, so we would basically free
all of the frames (as drops is 0, cnt = bq->count). After that we
recalculate drops and correct value will be reported in tracepoint.
(needed to explain it to myself)
>
> if (bq->xdp_prog) {
> to_send = ...
> if (!to_send) {
> ...
> }
> drops = cnt - to_send;
> }
>
> > sent = dev->netdev_ops->ndo_xdp_xmit(dev, to_send, bq->q, flags);
>
> If we don't have xdp_prog, the to_send should be cnt.
Yes, we should init to_send to cnt as you're suggesting above.
>
> > if (sent < 0) {
> > err = sent;
> > sent = 0;
> >
> > /* If ndo_xdp_xmit fails with an errno, no frames have been
> > * xmit'ed and it's our responsibility to them free all.
> > */
> > for (i = 0; i < cnt - drops; i++) {
> > struct xdp_frame *xdpf = bq->q[i];
> >
> > xdp_return_frame_rx_napi(xdpf);
> > }
> > }
> > out:
> > drops = cnt - sent;
> > bq->count = 0;
> >
> > trace_xdp_devmap_xmit(bq->dev_rx, dev, sent, drops, err);
> > bq->dev_rx = NULL;
> > bq->xdp_prog = NULL;
> > __list_del_clearprev(&bq->flush_node);
> >
> > return;
> > }
>
> Thanks for your code, looks much clear now.
Good to hear! I agree on your points as well.
>
> Hangbin
next prev parent reply other threads:[~2021-01-21 13:58 UTC|newest]
Thread overview: 219+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 8:54 [RFC PATCH bpf-next 0/2] xdp: add dev map multicast support Hangbin Liu
2020-04-15 8:54 ` [RFC PATCH bpf-next 1/2] " Hangbin Liu
2020-04-20 9:52 ` Hangbin Liu
2020-04-15 8:54 ` [RFC PATCH bpf-next 2/2] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2020-04-24 8:56 ` [RFC PATCHv2 bpf-next 0/2] xdp: add dev map multicast support Hangbin Liu
2020-04-24 8:56 ` [RFC PATCHv2 bpf-next 1/2] xdp: add a new helper for " Hangbin Liu
2020-04-24 14:19 ` Lorenzo Bianconi
2020-04-28 11:09 ` Eelco Chaudron
2020-05-06 9:35 ` Hangbin Liu
2020-04-24 14:34 ` Toke Høiland-Jørgensen
2020-05-06 9:14 ` Hangbin Liu
2020-05-06 10:00 ` Toke Høiland-Jørgensen
2020-05-08 8:53 ` Hangbin Liu
2020-05-08 14:58 ` Toke Høiland-Jørgensen
2020-05-18 8:45 ` Hangbin Liu
2020-05-19 10:15 ` Jesper Dangaard Brouer
2020-05-20 1:24 ` Hangbin Liu
2020-04-24 8:56 ` [RFC PATCHv2 bpf-next 2/2] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2020-04-24 14:21 ` Lorenzo Bianconi
2020-05-23 6:05 ` [PATCHv3 bpf-next 0/2] xdp: add dev map multicast support Hangbin Liu
2020-05-23 6:05 ` [PATCHv3 bpf-next 1/2] xdp: add a new helper for " Hangbin Liu
2020-05-26 7:34 ` kbuild test robot
2020-05-23 6:05 ` [PATCHv3 bpf-next 2/2] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2020-05-26 14:05 ` [PATCHv4 bpf-next 0/2] xdp: add dev map multicast support Hangbin Liu
2020-05-26 14:05 ` [PATCHv4 bpf-next 1/2] xdp: add a new helper for " Hangbin Liu
2020-05-27 10:29 ` Toke Høiland-Jørgensen
2020-06-10 10:18 ` Jesper Dangaard Brouer
2020-06-12 8:54 ` Hangbin Liu
2020-06-16 8:55 ` Jesper Dangaard Brouer
2020-06-16 10:11 ` Hangbin Liu
2020-06-16 14:38 ` Jesper Dangaard Brouer
2020-06-10 10:21 ` Jesper Dangaard Brouer
2020-06-10 10:29 ` Toke Høiland-Jørgensen
2020-06-16 9:04 ` Jesper Dangaard Brouer
2020-05-26 14:05 ` [PATCHv4 bpf-next 2/2] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2020-05-27 10:21 ` [PATCHv4 bpf-next 0/2] xdp: add dev map multicast support Toke Høiland-Jørgensen
2020-05-27 10:32 ` Eelco Chaudron
2020-05-27 12:38 ` Hangbin Liu
2020-05-27 15:04 ` Toke Høiland-Jørgensen
2020-06-16 9:09 ` Jesper Dangaard Brouer
2020-06-16 9:47 ` Hangbin Liu
2020-06-03 2:40 ` Hangbin Liu
2020-06-03 11:05 ` Toke Høiland-Jørgensen
2020-06-04 4:09 ` Hangbin Liu
2020-06-04 9:44 ` Toke Høiland-Jørgensen
2020-06-04 12:12 ` Hangbin Liu
2020-06-04 12:37 ` Toke Høiland-Jørgensen
2020-06-04 14:41 ` Hangbin Liu
2020-06-04 16:02 ` Toke Høiland-Jørgensen
2020-06-05 6:26 ` Hangbin Liu
2020-06-08 15:32 ` Toke Høiland-Jørgensen
2020-06-09 3:03 ` Hangbin Liu
2020-06-09 20:31 ` Toke Høiland-Jørgensen
2020-06-10 2:35 ` Hangbin Liu
2020-06-10 10:03 ` Jesper Dangaard Brouer
2020-07-01 4:19 ` [PATCHv5 bpf-next 0/3] xdp: add a new helper for " Hangbin Liu
2020-07-01 4:19 ` [PATCHv5 bpf-next 1/3] " Hangbin Liu
2020-07-01 5:09 ` Andrii Nakryiko
2020-07-01 6:51 ` Hangbin Liu
2020-07-01 18:33 ` kernel test robot
2020-07-01 4:19 ` [PATCHv5 bpf-next 2/3] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2020-07-01 4:19 ` [PATCHv5 bpf-next 3/3] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2020-07-09 1:30 ` [PATCHv6 bpf-next 0/3] xdp: add a new helper for dev map multicast support Hangbin Liu
2020-07-09 1:30 ` [PATCHv6 bpf-next 1/3] " Hangbin Liu
2020-07-09 16:33 ` David Ahern
2020-07-10 6:55 ` Hangbin Liu
2020-07-10 13:46 ` David Ahern
2020-07-11 0:26 ` Hangbin Liu
2020-07-11 16:09 ` David Ahern
2020-07-09 1:30 ` [PATCHv6 bpf-next 2/3] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2020-07-09 22:40 ` Daniel Borkmann
2020-07-10 6:41 ` Hangbin Liu
2020-07-10 14:32 ` Daniel Borkmann
2020-07-11 0:21 ` Hangbin Liu
2020-07-09 1:30 ` [PATCHv6 bpf-next 3/3] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2020-07-09 22:37 ` [PATCHv6 bpf-next 0/3] xdp: add a new helper for dev map multicast support Daniel Borkmann
2020-07-10 7:36 ` Hangbin Liu
2020-07-10 15:02 ` Daniel Borkmann
2020-07-10 16:52 ` David Ahern
2020-07-14 6:32 ` [PATCHv7 " Hangbin Liu
2020-07-14 6:32 ` [PATCHv7 bpf-next 1/3] " Hangbin Liu
2020-07-14 21:52 ` Toke Høiland-Jørgensen
2020-07-15 12:25 ` Hangbin Liu
2020-07-14 6:32 ` [PATCHv7 bpf-next 2/3] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2020-07-14 6:32 ` [PATCHv7 bpf-next 3/3] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2020-07-14 12:29 ` [PATCHv7 bpf-next 0/3] xdp: add a new helper for dev map multicast support Toke Høiland-Jørgensen
2020-07-14 17:12 ` David Ahern
2020-07-14 21:53 ` Toke Høiland-Jørgensen
2020-07-15 12:31 ` Hangbin Liu
2020-07-15 3:45 ` Hangbin Liu
2020-07-15 13:08 ` [PATCHv8 " Hangbin Liu
2020-07-15 13:08 ` [PATCHv8 bpf-next 1/3] " Hangbin Liu
2020-07-15 13:08 ` [PATCHv8 bpf-next 2/3] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2020-07-15 13:08 ` [PATCHv8 bpf-next 3/3] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2020-08-26 13:19 ` [PATCHv9 bpf-next 0/5] xdp: add a new helper for dev map multicast support Hangbin Liu
2020-08-26 13:19 ` [PATCHv9 bpf-next 1/5] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2020-08-28 21:56 ` Daniel Borkmann
2020-09-03 9:15 ` Hangbin Liu
2020-08-26 13:19 ` [PATCHv9 bpf-next 2/5] xdp: add a new helper for dev map multicast support Hangbin Liu
2020-08-28 22:05 ` Daniel Borkmann
2020-08-26 13:20 ` [PATCHv9 bpf-next 3/5] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2020-08-26 13:20 ` [PATCHv9 bpf-next 4/5] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2020-08-26 13:20 ` [PATCHv9 bpf-next 5/5] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2020-09-03 10:26 ` [PATCHv10 bpf-next 0/5] xdp: add a new helper for dev map multicast support Hangbin Liu
2020-09-03 10:26 ` [PATCHv10 bpf-next 1/5] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2020-09-04 14:26 ` Daniel Borkmann
2020-09-03 10:26 ` [PATCHv10 bpf-next 2/5] xdp: add a new helper for dev map multicast support Hangbin Liu
2020-09-04 14:22 ` Daniel Borkmann
2020-09-03 10:26 ` [PATCHv10 bpf-next 3/5] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2020-09-03 10:27 ` [PATCHv10 bpf-next 4/5] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2020-09-03 10:27 ` [PATCHv10 bpf-next 5/5] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2020-09-07 8:27 ` [PATCHv11 bpf-next 0/5] xdp: add a new helper for dev map multicast support Hangbin Liu
2020-09-07 8:27 ` [PATCHv11 bpf-next 1/5] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2020-09-07 8:27 ` [PATCHv11 bpf-next 2/5] xdp: add a new helper for dev map multicast support Hangbin Liu
2020-09-09 21:52 ` Alexei Starovoitov
2020-09-10 2:35 ` Hangbin Liu
2020-09-10 3:30 ` David Ahern
2020-09-10 5:35 ` Alexei Starovoitov
2020-09-10 9:44 ` Toke Høiland-Jørgensen
2020-09-10 15:39 ` Alexei Starovoitov
2020-09-10 17:50 ` Jesper Dangaard Brouer
2020-09-10 18:35 ` David Ahern
2020-09-11 7:58 ` Jesper Dangaard Brouer
2020-09-15 16:12 ` David Ahern
2020-09-07 8:27 ` [PATCHv11 bpf-next 3/5] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2020-09-07 8:27 ` [PATCHv11 bpf-next 4/5] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2020-09-07 8:27 ` [PATCHv11 bpf-next 5/5] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2020-12-16 14:30 ` [PATCHv12 bpf-next 0/6] xdp: add a new helper for dev map multicast support Hangbin Liu
2020-12-16 14:30 ` [PATCHv12 bpf-next 1/6] bpf: run devmap xdp_prog on flush instead of bulk enqueue Hangbin Liu
2020-12-17 16:07 ` David Ahern
2020-12-18 9:43 ` Hangbin Liu
2020-12-21 8:38 ` Hangbin Liu
2020-12-16 14:30 ` [PATCHv12 bpf-next 2/6] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2020-12-16 14:30 ` [PATCHv12 bpf-next 3/6] xdp: add a new helper for dev map multicast support Hangbin Liu
2020-12-16 14:30 ` [PATCHv12 bpf-next 4/6] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2020-12-16 14:30 ` [PATCHv12 bpf-next 5/6] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2020-12-16 14:30 ` [PATCHv12 bpf-next 6/6] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2020-12-21 12:34 ` [PATCHv13 bpf-next 0/6] xdp: add a new helper for dev map multicast support Hangbin Liu
2020-12-21 12:35 ` [PATCHv13 bpf-next 1/6] bpf: run devmap xdp_prog on flush instead of bulk enqueue Hangbin Liu
2020-12-21 12:35 ` [PATCHv13 bpf-next 2/6] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2020-12-21 12:35 ` [PATCHv13 bpf-next 3/6] xdp: add a new helper for dev map multicast support Hangbin Liu
2020-12-21 12:35 ` [PATCHv13 bpf-next 4/6] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2020-12-21 12:35 ` [PATCHv13 bpf-next 5/6] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2020-12-21 12:35 ` [PATCHv13 bpf-next 6/6] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2021-01-14 14:23 ` [PATCHv14 bpf-next 0/6] xdp: add a new helper for dev map multicast support Hangbin Liu
2021-01-14 14:23 ` [PATCHv14 bpf-next 1/6] bpf: run devmap xdp_prog on flush instead of bulk enqueue Hangbin Liu
2021-01-17 22:57 ` John Fastabend
2021-01-18 10:07 ` Hangbin Liu
2021-01-21 14:33 ` Jesper Dangaard Brouer
2021-01-14 14:23 ` [PATCHv14 bpf-next 2/6] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2021-01-14 14:23 ` [PATCHv14 bpf-next 3/6] xdp: add a new helper for dev map multicast support Hangbin Liu
2021-01-18 0:10 ` John Fastabend
2021-01-18 8:44 ` Hangbin Liu
2021-01-18 10:47 ` Toke Høiland-Jørgensen
2021-01-18 15:14 ` John Fastabend
2021-01-14 14:23 ` [PATCHv14 bpf-next 4/6] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2021-01-14 14:23 ` [PATCHv14 bpf-next 5/6] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2021-01-14 14:23 ` [PATCHv14 bpf-next 6/6] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2021-01-20 2:25 ` [PATCHv15 bpf-next 0/6] xdp: add a new helper for dev map multicast support Hangbin Liu
2021-01-20 2:25 ` [PATCHv15 bpf-next 1/6] bpf: run devmap xdp_prog on flush instead of bulk enqueue Hangbin Liu
2021-01-20 22:42 ` Maciej Fijalkowski
2021-01-21 3:54 ` Hangbin Liu
2021-01-21 13:35 ` Maciej Fijalkowski [this message]
2021-01-20 2:25 ` [PATCHv15 bpf-next 2/6] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2021-01-20 2:25 ` [PATCHv15 bpf-next 3/6] xdp: add a new helper for dev map multicast support Hangbin Liu
2021-01-20 2:25 ` [PATCHv15 bpf-next 4/6] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2021-01-20 2:25 ` [PATCHv15 bpf-next 5/6] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2021-01-20 2:25 ` [PATCHv15 bpf-next 6/6] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2021-01-22 7:46 ` [PATCHv16 bpf-next 0/6] xdp: add a new helper for dev map multicast support Hangbin Liu
2021-01-22 7:46 ` [PATCHv16 bpf-next 1/6] bpf: run devmap xdp_prog on flush instead of bulk enqueue Hangbin Liu
2021-01-22 10:50 ` Maciej Fijalkowski
2021-01-22 13:38 ` Toke Høiland-Jørgensen
2021-01-25 3:30 ` Hangbin Liu
2021-01-25 11:21 ` Toke Høiland-Jørgensen
2021-01-25 12:29 ` Maciej Fijalkowski
2021-01-22 7:46 ` [PATCHv16 bpf-next 2/6] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2021-01-22 7:46 ` [PATCHv16 bpf-next 3/6] xdp: add a new helper for dev map multicast support Hangbin Liu
2021-01-25 12:27 ` Maciej Fijalkowski
2021-01-26 1:17 ` Hangbin Liu
2021-01-27 22:13 ` John Fastabend
2021-01-22 7:46 ` [PATCHv16 bpf-next 4/6] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2021-01-22 7:46 ` [PATCHv16 bpf-next 5/6] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2021-01-22 7:46 ` [PATCHv16 bpf-next 6/6] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2021-01-22 13:43 ` [PATCHv16 bpf-next 0/6] xdp: add a new helper for dev map multicast support Toke Høiland-Jørgensen
2021-01-25 12:45 ` [PATCHv17 " Hangbin Liu
2021-01-25 12:45 ` [PATCHv17 bpf-next 1/6] bpf: run devmap xdp_prog on flush instead of bulk enqueue Hangbin Liu
2021-01-27 7:37 ` John Fastabend
2021-01-27 9:41 ` Toke Høiland-Jørgensen
2021-01-27 12:20 ` Maciej Fijalkowski
2021-01-27 15:00 ` Jesper Dangaard Brouer
2021-01-27 15:52 ` John Fastabend
2021-01-27 16:05 ` Toke Høiland-Jørgensen
2021-01-27 15:58 ` Jesper Dangaard Brouer
2021-01-25 12:45 ` [PATCHv17 bpf-next 2/6] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2021-01-27 21:50 ` John Fastabend
2021-01-25 12:45 ` [PATCHv17 bpf-next 3/6] xdp: add a new helper for dev map multicast support Hangbin Liu
2021-01-25 12:45 ` [PATCHv17 bpf-next 4/6] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2021-01-25 12:45 ` [PATCHv17 bpf-next 5/6] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2021-01-27 22:24 ` John Fastabend
2021-01-28 3:53 ` Hangbin Liu
2021-01-28 23:14 ` John Fastabend
2021-01-25 12:45 ` [PATCHv17 bpf-next 6/6] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2021-01-28 23:37 ` John Fastabend
2021-01-29 1:46 ` Hangbin Liu
2021-02-04 0:14 ` [PATCHv17 bpf-next 0/6] xdp: add a new helper for dev map multicast support Hangbin Liu
2021-02-04 2:53 ` John Fastabend
2021-02-04 3:12 ` Hangbin Liu
2021-02-04 11:00 ` Toke Høiland-Jørgensen
2021-02-04 12:09 ` Maciej Fijalkowski
2021-02-04 13:33 ` Hangbin Liu
2021-02-04 17:03 ` Jakub Kicinski
2021-02-05 3:07 ` Hangbin Liu
2021-02-04 14:03 ` [PATCHv18 " Hangbin Liu
2021-02-04 14:03 ` [PATCHv18 bpf-next 1/6] bpf: run devmap xdp_prog on flush instead of bulk enqueue Hangbin Liu
2021-02-04 14:03 ` [PATCHv18 bpf-next 2/6] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2021-02-04 14:03 ` [PATCHv18 bpf-next 3/6] xdp: add a new helper for dev map multicast support Hangbin Liu
2021-02-04 14:03 ` [PATCHv18 bpf-next 4/6] sample/bpf: add xdp_redirect_map_multicast test Hangbin Liu
2021-02-04 14:03 ` [PATCHv18 bpf-next 5/6] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL Hangbin Liu
2021-02-04 14:03 ` [PATCHv18 bpf-next 6/6] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121133538.GA41935@ranger.igk.intel.com \
--to=maciej.fijalkowski@intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=echaudro@redhat.com \
--cc=jbenc@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=liuhangbin@gmail.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).