From: Jakub Kicinski <kuba@kernel.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: netdev@vger.kernel.org, SinYu <liuxyon@gmail.com>,
Willem de Bruijn <willemb@google.com>,
David L Stevens <david.stevens@oracle.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net v4] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending
Date: Mon, 22 Feb 2021 18:44:32 -0800 [thread overview]
Message-ID: <20210222184432.5888c1e7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210219022532.2446968-1-Jason@zx2c4.com>
On Fri, 19 Feb 2021 03:25:32 +0100 Jason A. Donenfeld wrote:
> This commit fixes the issue by passing an empty IPCB or IP6CB along to
> the functions that actually do the work. For the icmp_send, this was
> already trivial, thanks to __icmp_send providing the plumbing function.
> For icmpv6_send, this required a tiny bit of refactoring to make it
> behave like the v4 case, after which it was straight forward.
No longer applies after the net-next merge.
Could you respin?
next prev parent reply other threads:[~2021-02-23 2:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 2:25 [PATCH net v4] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending Jason A. Donenfeld
2021-02-19 15:16 ` Willem de Bruijn
2021-02-23 2:44 ` Jakub Kicinski [this message]
2021-02-23 13:18 ` [PATCH net v5] " Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222184432.5888c1e7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=david.stevens@oracle.com \
--cc=liuxyon@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).