From: Kalle Valo <kvalo@codeaurora.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
Luca Coelho <luciano.coelho@intel.com>,
Jakub Kicinski <kuba@kernel.org>,
"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
Gil Adam <gil.adam@intel.com>,
Mordechay Goodstein <mordechay.goodstein@intel.com>,
Johannes Berg <johannes.berg@intel.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: iwlwifi: mvm: add terminate entry for dmi_system_id tables
Date: Wed, 3 Mar 2021 15:57:04 +0000 (UTC) [thread overview]
Message-ID: <20210303155704.917D5C433C6@smtp.codeaurora.org> (raw)
In-Reply-To: <20210223140039.1708534-1-weiyongjun1@huawei.com>
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Make sure dmi_system_id tables are NULL terminated. This crashed when LTO was enabled:
>
> BUG: KASAN: global-out-of-bounds in dmi_check_system+0x5a/0x70
> Read of size 1 at addr ffffffffc16af750 by task NetworkManager/1913
>
> CPU: 4 PID: 1913 Comm: NetworkManager Not tainted 5.12.0-rc1+ #10057
> Hardware name: LENOVO 20THCTO1WW/20THCTO1WW, BIOS N2VET27W (1.12 ) 12/21/2020
> Call Trace:
> dump_stack+0x90/0xbe
> print_address_description.constprop.0+0x1d/0x140
> ? dmi_check_system+0x5a/0x70
> ? dmi_check_system+0x5a/0x70
> kasan_report.cold+0x7b/0xd4
> ? dmi_check_system+0x5a/0x70
> __asan_load1+0x4d/0x50
> dmi_check_system+0x5a/0x70
> iwl_mvm_up+0x1360/0x1690 [iwlmvm]
> ? iwl_mvm_send_recovery_cmd+0x270/0x270 [iwlmvm]
> ? setup_object.isra.0+0x27/0xd0
> ? kasan_poison+0x20/0x50
> ? ___slab_alloc.constprop.0+0x483/0x5b0
> ? mempool_kmalloc+0x17/0x20
> ? ftrace_graph_ret_addr+0x2a/0xb0
> ? kasan_poison+0x3c/0x50
> ? cfg80211_iftype_allowed+0x2e/0x90 [cfg80211]
> ? __kasan_check_write+0x14/0x20
> ? mutex_lock+0x86/0xe0
> ? __mutex_lock_slowpath+0x20/0x20
> __iwl_mvm_mac_start+0x49/0x290 [iwlmvm]
> iwl_mvm_mac_start+0x37/0x50 [iwlmvm]
> drv_start+0x73/0x1b0 [mac80211]
> ieee80211_do_open+0x53e/0xf10 [mac80211]
> ? ieee80211_check_concurrent_iface+0x266/0x2e0 [mac80211]
> ieee80211_open+0xb9/0x100 [mac80211]
> __dev_open+0x1b8/0x280
>
> Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG feature")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> Tested-by: Victor Michel <vic.michel.web@gmail.com>
> Acked-by: Luca Coelho <luciano.coelho@intel.com>
> [kvalo@codeaurora.org: improve commit log]
Patch applied to wireless-drivers.git, thanks.
a22549f12767 iwlwifi: mvm: add terminate entry for dmi_system_id tables
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210223140039.1708534-1-weiyongjun1@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-03-04 0:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 14:00 [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables Wei Yongjun
2021-02-26 21:06 ` Nathan Chancellor
2021-02-27 6:39 ` Kalle Valo
2021-03-02 18:31 ` Coelho, Luciano
2021-03-02 19:05 ` Jakub Kicinski
2021-03-02 19:50 ` Kalle Valo
2021-03-02 21:42 ` Jakub Kicinski
2021-03-03 6:45 ` Coelho, Luciano
2021-02-26 21:37 ` vic.michel.web
2021-03-03 15:57 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303155704.917D5C433C6@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=emmanuel.grumbach@intel.com \
--cc=gil.adam@intel.com \
--cc=hulkci@huawei.com \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=mordechay.goodstein@intel.com \
--cc=netdev@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).