From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: aelior@marvell.com, skalluru@marvell.com,
GR-everest-linux-l2@marvell.com, kuba@kernel.org,
eilong@broadcom.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bnx2x: Fix potential infinite loop
Date: Wed, 07 Apr 2021 15:13:10 -0700 (PDT) [thread overview]
Message-ID: <20210407.151310.197667379826410564.davem@davemloft.net> (raw)
In-Reply-To: <20210407142802.495539-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Wed, 7 Apr 2021 15:28:02 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The for_each_tx_queue loop iterates with a u8 loop counter i and
> compares this with the loop upper limit of bp->num_queues that
> is an int type. There is a potential infinite loop if bp->num_queues
> is larger than the u8 loop counter. Fix this by making the loop
> counter the same type as bp->num_queues.
>
> Addresses-Coverity: ("Infinite loop")
> Fixes: ad5afc89365e ("bnx2x: Separate VF and PF logic")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Please show how num_queues can take on a value larger than 255.
Thank you.
next prev parent reply other threads:[~2021-04-07 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 14:28 [PATCH] bnx2x: Fix potential infinite loop Colin King
2021-04-07 22:13 ` David Miller [this message]
2021-04-08 1:44 ` [EXT] " Sudarsana Reddy Kalluru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407.151310.197667379826410564.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=colin.king@canonical.com \
--cc=eilong@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).