From: Danielle Ratson <danieller@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>,
<eric.dumazet@gmail.com>, <andrew@lunn.ch>, <mkubecek@suse.cz>,
<f.fainelli@gmail.com>, <acardace@redhat.com>,
<irusskikh@marvell.com>, <gustavo@embeddedor.com>,
<magnus.karlsson@intel.com>, <ecree@solarflare.com>,
<idosch@nvidia.com>, <jiri@nvidia.com>, <mlxsw@nvidia.com>,
Danielle Ratson <danieller@nvidia.com>
Subject: [PATCH net v3 2/2] ethtool: Add lanes parameter for ETHTOOL_LINK_MODE_10000baseR_FEC_BIT
Date: Wed, 7 Apr 2021 13:06:52 +0300 [thread overview]
Message-ID: <20210407100652.2150415-3-danieller@nvidia.com> (raw)
In-Reply-To: <20210407100652.2150415-1-danieller@nvidia.com>
Lanes field is missing for ETHTOOL_LINK_MODE_10000baseR_FEC_BIT
link mode and it causes a failure when trying to set
'speed 10000 lanes 1' on Spectrum-2 machines when autoneg is set to on.
Add the lanes parameter for ETHTOOL_LINK_MODE_10000baseR_FEC_BIT
link mode.
Fixes: c8907043c6ac9 ("ethtool: Get link mode in use instead of speed and duplex parameters")
Signed-off-by: Danielle Ratson <danieller@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
---
net/ethtool/common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ethtool/common.c b/net/ethtool/common.c
index 030aa7984a91..f9dcbad84788 100644
--- a/net/ethtool/common.c
+++ b/net/ethtool/common.c
@@ -273,6 +273,7 @@ const struct link_mode_info link_mode_params[] = {
__DEFINE_LINK_MODE_PARAMS(10000, KR, Full),
[ETHTOOL_LINK_MODE_10000baseR_FEC_BIT] = {
.speed = SPEED_10000,
+ .lanes = 1,
.duplex = DUPLEX_FULL,
},
__DEFINE_LINK_MODE_PARAMS(20000, MLD2, Full),
--
2.26.2
next prev parent reply other threads:[~2021-04-07 10:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 10:06 [PATCH net v3 0/2] Fix link_mode derived params functionality Danielle Ratson
2021-04-07 10:06 ` [PATCH net v3 1/2] ethtool: Remove link_mode param and derive link params from driver Danielle Ratson
2021-04-07 10:06 ` Danielle Ratson [this message]
2021-04-07 22:10 ` [PATCH net v3 0/2] Fix link_mode derived params functionality patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407100652.2150415-3-danieller@nvidia.com \
--to=danieller@nvidia.com \
--cc=acardace@redhat.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=idosch@nvidia.com \
--cc=irusskikh@marvell.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).