From: Jakub Kicinski <kuba@kernel.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, john@phrozen.org,
nbd@nbd.name, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com,
dqfext@gmail.com, frank-w@public-files.de
Subject: Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex
Date: Mon, 19 Apr 2021 14:43:41 -0700 [thread overview]
Message-ID: <20210419144341.159bde8a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210419214019.GA8535@salvia>
On Mon, 19 Apr 2021 23:40:19 +0200 Pablo Neira Ayuso wrote:
> On Mon, Apr 19, 2021 at 02:16:01PM -0700, Jakub Kicinski wrote:
> > On Sun, 18 Apr 2021 23:11:44 +0200 Pablo Neira Ayuso wrote:
> > > Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy and
> > > stats to different workqueues") splits the workqueue per event type. Add
> > > a mutex to serialize updates.
> > >
> > > Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support")
> > > Reported-by: Frank Wunderlich <frank-w@public-files.de>
> > > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> >
> > This driver doesn't set unlocked_driver_cb, why is it expected to take
> > any locks? I thought the contract is that caller should hold rtnl.
>
> No rtnl lock is held from the netfilter side, see:
>
> 42f1c2712090 ("netfilter: nftables: comment indirect serialization of
> commit_mutex with rtnl_mutex")
All the tc-centric drivers but mlx5 depend on rtnl_lock, is there
something preventing them from binding to netfilter blocks?
next prev parent reply other threads:[~2021-04-19 21:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 21:11 [PATCH net-next 0/3] mtk_ppe_offload fixes Pablo Neira Ayuso
2021-04-18 21:11 ` [PATCH net-next 1/3] net: ethernet: mtk_eth_soc: fix undefined reference to `dsa_port_from_netdev' Pablo Neira Ayuso
2021-04-18 21:11 ` [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex Pablo Neira Ayuso
2021-04-19 21:16 ` Jakub Kicinski
2021-04-19 21:40 ` Pablo Neira Ayuso
2021-04-19 21:43 ` Jakub Kicinski [this message]
2021-04-19 21:54 ` Pablo Neira Ayuso
2021-04-19 21:56 ` Jakub Kicinski
2021-04-20 11:51 ` Frank Wunderlich
2021-04-20 14:58 ` Pablo Neira Ayuso
2021-04-18 21:11 ` [PATCH net-next 3/3] net: ethernet: mtk_eth_soc: handle VLAN pop action Pablo Neira Ayuso
2021-04-19 23:10 ` [PATCH net-next 0/3] mtk_ppe_offload fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419144341.159bde8a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=frank-w@public-files.de \
--cc=john@phrozen.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).