From: "Michal Suchánek" <msuchanek@suse.de>
To: Jiri Slaby <jslaby@suse.com>
Cc: Jiri Olsa <jolsa@redhat.com>, Yonghong Song <yhs@fb.com>,
linux-kernel@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
"David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
Jiri Olsa <jolsa@kernel.org>,
Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: linux-next failing build due to missing cubictcp_state symbol
Date: Sat, 1 May 2021 12:54:00 +0200 [thread overview]
Message-ID: <20210501105400.GG6564@kitsune.suse.cz> (raw)
In-Reply-To: <3d148516-0472-8f0a-085b-94d68c5cc0d5@suse.com>
On Sat, May 01, 2021 at 08:45:50AM +0200, Jiri Slaby wrote:
> On 30. 04. 21, 19:47, Michal Suchánek wrote:
> > CC another Jiri
> >
> > On Tue, Apr 27, 2021 at 02:12:37PM +0200, Michal Suchánek wrote:
> > > On Mon, Apr 26, 2021 at 09:16:36PM +0200, Jiri Olsa wrote:
> > > > On Mon, Apr 26, 2021 at 06:03:19PM +0200, Jiri Olsa wrote:
> > > > > On Mon, Apr 26, 2021 at 08:41:49AM -0700, Yonghong Song wrote:
> > > > > >
> > > > > >
> > > > > > On 4/26/21 5:14 AM, Michal Suchánek wrote:
> > > > > > > On Mon, Apr 26, 2021 at 02:12:20PM +0200, Michal Suchánek wrote:
> > > > > > > > On Mon, Apr 26, 2021 at 01:32:15PM +0200, Michal Suchánek wrote:
> > > > > > > > > On Sun, Apr 25, 2021 at 01:15:45PM +0200, Michal Suchánek wrote:
> > > > > > > > > > On Fri, Apr 23, 2021 at 07:55:28PM +0200, Michal Suchánek wrote:
> > > > > > > > > > > On Fri, Apr 23, 2021 at 07:41:29AM -0700, Yonghong Song wrote:
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > On 4/23/21 6:05 AM, Michal Suchánek wrote:
> > > > > > > > > > > > > Hello,
> > > > > > > > > > > > >
> > > > > > > > > > > > > I see this build error in linux-next (config attached).
> > > > > > > > > > > > >
> > > > > > > > > > > > > [ 4939s] LD vmlinux
> > > > > > > > > > > > > [ 4959s] BTFIDS vmlinux
> > > > > > > > > > > > > [ 4959s] FAILED unresolved symbol cubictcp_state
> > > > > > > > > > > > > [ 4960s] make[1]: ***
> > > > > > > > > > > > > [/home/abuild/rpmbuild/BUILD/kernel-vanilla-5.12~rc8.next.20210422/linux-5.12-rc8-next-20210422/Makefile:1277:
> > > > > > > > > > > > > vmlinux] Error 255
> > > > > > > > > > > > > [ 4960s] make: *** [../Makefile:222: __sub-make] Error 2
> > > > >
> > > > > this one was reported by Jesper and was fixed by upgrading pahole
> > > > > that contains the new function generation fixes (v1.19)
> > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > Looks like you have DYNAMIC_FTRACE config option enabled already.
> > > > > > > > > > > > Could you try a later version of pahole?
> > > > > > > > > > >
> > > > > > > > > > > Is this requireent new?
> > > > > > > > > > >
> > > > > > > > > > > I have pahole 1.20, and master does build without problems.
> > > > > > > > > > >
> > > > > > > > > > > If newer version is needed can a check be added?
> > > > > > > > > >
> > > > > > > > > > With dwarves 1.21 some architectures are fixed and some report other
> > > > > > > > > > missing symbol. Definitely an improvenent.
> > > > > > > > > >
> > > > > > > > > > I see some new type support was added so it makes sense if that type is
> > > > > > > > > > used the new dwarves are needed.
> > > > > > > > >
> > > > > > > > > Ok, here is the current failure with dwarves 1.21 on 5.12:
> > > > > > > > >
> > > > > > > > > [ 2548s] LD vmlinux
> > > > > > > > > [ 2557s] BTFIDS vmlinux
> > > > > > > > > [ 2557s] FAILED unresolved symbol vfs_truncate
> > > > > > > > > [ 2558s] make[1]: ***
> > > > > > > > > [/home/abuild/rpmbuild/BUILD/kernel-kvmsmall-5.12.0/linux-5.12/Makefile:1213:
> > > > > > > > > vmlinux] Error 255
> > > > > >
> > > > > > This is PPC64, from attached config:
> > > > > > CONFIG_PPC64=y
> > > > > > I don't have environment to cross-compile for PPC64.
> > > > > > Jiri, could you take a look? Thanks!
> > > > >
> > > > > looks like vfs_truncate did not get into BTF data,
> > > > > I'll try to reproduce
>
> _None_ of the functions are generated by pahole -J from debuginfo on ppc64.
> debuginfo appears to be correct. Neither pahole -J fs/open.o works
> correctly. collect_functions in dwarves seems to be defunct on ppc64...
> "functions" array is bogus (so find_function -- the bsearch -- fails). I
> didn't have more time to continue debugging. This is where I stopped.
A workaround is to apply
https://lore.kernel.org/linuxppc-dev/20200428112517.1402927-1-npiggin@gmail.com/
and build as ABI v2
Thanks
Michal
next prev parent reply other threads:[~2021-05-01 10:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 13:05 linux-next failing build due to missing cubictcp_state symbol Michal Suchánek
2021-04-23 14:41 ` Yonghong Song
2021-04-23 17:55 ` Michal Suchánek
2021-04-25 11:15 ` Michal Suchánek
2021-04-26 11:32 ` Michal Suchánek
2021-04-26 12:12 ` Michal Suchánek
2021-04-26 12:14 ` Michal Suchánek
2021-04-26 15:41 ` Yonghong Song
2021-04-26 16:03 ` Jiri Olsa
2021-04-26 19:16 ` Jiri Olsa
2021-04-27 12:12 ` Michal Suchánek
2021-04-30 17:47 ` Michal Suchánek
2021-04-30 18:26 ` Michal Suchánek
2021-05-01 6:45 ` Jiri Slaby
2021-05-01 10:54 ` Michal Suchánek [this message]
2021-05-03 6:11 ` Jiri Slaby
2021-05-03 7:13 ` Michal Suchánek
2021-05-03 7:59 ` Jiri Slaby
2021-05-03 8:59 ` Jiri Slaby
2021-05-03 10:08 ` Jiri Olsa
2021-05-03 16:46 ` Michal Suchánek
2021-05-03 16:58 ` Michal Suchánek
2021-05-04 6:41 ` Jiri Slaby
2021-05-06 5:31 ` Martin KaFai Lau
2021-05-06 13:16 ` Jiri Olsa
2021-05-07 7:10 ` Florian Weimer
2021-05-05 13:56 ` Michal Suchánek
2021-05-06 4:31 ` Jiri Slaby
2021-05-06 5:20 ` Martin KaFai Lau
2021-05-06 5:54 ` Jiri Slaby
2021-05-06 8:19 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210501105400.GG6564@kitsune.suse.cz \
--to=msuchanek@suse.de \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=jslaby@suse.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).