From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Schrempf Frieder <frieder.schrempf@kontron.de>
Cc: "Vincent Mailhol" <mailhol.vincent@wanadoo.fr>,
"Oliver Hartkopp" <socketcan@hartkopp.net>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Timo Schlüßler" <schluessler@krause.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Tim Harvey" <tharvey@gateworks.com>,
stable@vger.kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: mcp251x: Fix resume from sleep before interface was brought up
Date: Tue, 4 May 2021 20:48:54 +0200 [thread overview]
Message-ID: <20210504184854.urgotqioxtjwbqqs@pengutronix.de> (raw)
In-Reply-To: <bd466d82-db03-38b1-0a13-86aa124680ea@kontron.de>
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
On 04.05.2021 18:01:48, Schrempf Frieder wrote:
> Since 8ce8c0abcba3 the driver queues work via priv->restart_work when
> resuming after suspend, even when the interface was not previously
> enabled. This causes a null dereference error as the workqueue is
> only allocated and initialized in mcp251x_open().
>
> To fix this we move the workqueue init to mcp251x_can_probe() as
> there is no reason to do it later and repeat it whenever
> mcp251x_open() is called.
>
> Fixes: 8ce8c0abcba3 ("can: mcp251x: only reset hardware as required")
> Cc: stable@vger.kernel.org
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Added to linux-can/testing.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-04 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 16:01 [PATCH] can: mcp251x: Fix resume from sleep before interface was brought up Schrempf Frieder
2021-05-04 16:24 ` Andy Shevchenko
2021-05-04 18:48 ` Marc Kleine-Budde [this message]
2021-05-04 19:40 ` Schlüßler, Timo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504184854.urgotqioxtjwbqqs@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=frieder.schrempf@kontron.de \
--cc=gustavoars@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=schluessler@krause.de \
--cc=socketcan@hartkopp.net \
--cc=stable@vger.kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).