From: Jakub Kicinski <kuba@kernel.org>
To: Alex Elder <elder@linaro.org>
Cc: davem@davemloft.net, bjorn.andersson@linaro.org,
evgreen@chromium.org, cpratapa@codeaurora.org,
subashab@codeaurora.org, elder@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: ipa: fix inter-EE IRQ register definitions
Date: Thu, 6 May 2021 17:03:14 -0700 [thread overview]
Message-ID: <20210506170314.64112387@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210505223636.232527-1-elder@linaro.org>
On Wed, 5 May 2021 17:36:36 -0500 Alex Elder wrote:
> In gsi_irq_setup(), two registers are written with the intention of
> disabling inter-EE channel and event IRQs.
>
> But the wrong registers are used (and defined); the ones used are
> read-only registers that indicate whether the interrupt condition is
> present.
>
> Define the mask registers instead of the status registers, and use
> them to disable the inter-EE interrupt types.
>
> Fixes: 46f748ccaf01 ("net: ipa: explicitly disallow inter-EE interrupts")
> Signed-off-by: Alex Elder <elder@linaro.org>
Applied, thanks!
prev parent reply other threads:[~2021-05-07 0:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 22:36 [PATCH net] net: ipa: fix inter-EE IRQ register definitions Alex Elder
2021-05-07 0:03 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506170314.64112387@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).