From: Jakub Kicinski <kuba@kernel.org>
To: "huangguangbin (A)" <huangguangbin2@huawei.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<michael.chan@broadcom.com>, <saeedm@nvidia.com>,
<leon@kernel.org>, <ecree.xilinx@gmail.com>,
<habetsm.xilinx@gmail.com>, <f.fainelli@gmail.com>,
<andrew@lunn.ch>, <mkubecek@suse.cz>, <ariela@nvidia.com>
Subject: Re: [PATCH net-next v2 0/6] ethtool: add standard FEC statistics
Date: Tue, 18 May 2021 10:30:56 -0700 [thread overview]
Message-ID: <20210518103056.4e8a8a6f@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <b5bb362e-a430-2cc8-291e-b407e306fd49@huawei.com>
On Tue, 18 May 2021 14:48:13 +0800 huangguangbin (A) wrote:
> On 2021/4/16 6:53, Jakub Kicinski wrote:
> > This set adds uAPI for reporting standard FEC statistics, and
> > implements it in a handful of drivers.
> >
> > The statistics are taken from the IEEE standard, with one
> > extra seemingly popular but not standard statistics added.
> >
> > The implementation is similar to that of the pause frame
> > statistics, user requests the stats by setting a bit
> > (ETHTOOL_FLAG_STATS) in the common ethtool header of
> > ETHTOOL_MSG_FEC_GET.
> >
> > Since standard defines the statistics per lane what's
> > reported is both total and per-lane counters:
> >
> > # ethtool -I --show-fec eth0
> > FEC parameters for eth0:
> > Configured FEC encodings: None
> > Active FEC encoding: None
> > Statistics:
> > corrected_blocks: 256
> > Lane 0: 255
> > Lane 1: 1
> > uncorrectable_blocks: 145
> > Lane 0: 128
> > Lane 1: 17
>
> Hi, I have a doubt that why active FEC encoding is None here?
> Should it actually be BaseR or RS if FEC statistics are reported?
Hi! Good point. The values in the example are collected from a netdevsim
based mock up which I used for testing the interface, not real hardware.
In reality seeing None and corrected/uncorrectable blocks is not valid.
That said please keep in mind that the statistics should not be reset
when settings are changed, so OFF + stats may happen.
next prev parent reply other threads:[~2021-05-18 17:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 22:53 [PATCH net-next v2 0/6] ethtool: add standard FEC statistics Jakub Kicinski
2021-04-15 22:53 ` [PATCH net-next v2 1/6] ethtool: move ethtool_stats_init Jakub Kicinski
2021-04-15 22:53 ` [PATCH net-next v2 2/6] ethtool: fec_prepare_data() - jump to error handling Jakub Kicinski
2021-04-15 22:53 ` [PATCH net-next v2 3/6] ethtool: add FEC statistics Jakub Kicinski
2021-04-15 22:53 ` [PATCH net-next v2 4/6] bnxt: implement ethtool::get_fec_stats Jakub Kicinski
2021-04-15 22:53 ` [PATCH net-next v2 5/6] sfc: ef10: " Jakub Kicinski
2021-04-20 15:13 ` Edward Cree
2021-04-20 18:24 ` Jakub Kicinski
2021-04-15 22:53 ` [PATCH net-next v2 6/6] mlx5: " Jakub Kicinski
2021-04-15 23:51 ` [PATCH net-next v2 0/6] ethtool: add standard FEC statistics Saeed Mahameed
2021-04-16 0:20 ` patchwork-bot+netdevbpf
2021-05-18 6:48 ` huangguangbin (A)
2021-05-18 17:30 ` Jakub Kicinski [this message]
2021-07-01 12:18 ` huangguangbin (A)
2021-07-01 15:42 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518103056.4e8a8a6f@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=ariela@nvidia.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=habetsm.xilinx@gmail.com \
--cc=huangguangbin2@huawei.com \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).