From: Jakub Kicinski <kuba@kernel.org>
To: Jordy Zomer <jordy@pwning.systems>
Cc: netdev@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Chas Williams <3chas3@gmail.com>,
linux-atm-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: [nicstar] make drain_scq explicitly unsigned
Date: Sat, 31 Jul 2021 09:33:51 -0700 [thread overview]
Message-ID: <20210731093351.39c0e305@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210731085429.510245-1-jordy@pwning.systems>
On Sat, 31 Jul 2021 10:54:28 +0200 Jordy Zomer wrote:
> The drain_scq function used to take a signed integer as a pos parameter.
> The only caller of this function passes an unsigned integer to it.
> Therefore to make it obviously safe, let's just make this an unsgined
> integer as this is used in pointer arithmetics.
>
> Signed-off-by: Jordy Zomer <jordy@pwning.systems>
Does not build.
next prev parent reply other threads:[~2021-07-31 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 8:54 [PATCH] atm: [nicstar] make drain_scq explicitly unsigned Jordy Zomer
2021-07-31 16:33 ` Jakub Kicinski [this message]
2021-09-29 14:46 ` kernel test robot
2021-09-29 22:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210731093351.39c0e305@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=3chas3@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jordy@pwning.systems \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).