From: Vladimir Oltean <olteanv@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, DENG Qingfang <dqfext@gmail.com>,
Mauri Sandberg <sandberg@mailfence.com>
Subject: Re: [PATCH net] net: dsa: tag_rtl4_a: Fix egress tags
Date: Mon, 30 Aug 2021 10:29:13 +0300 [thread overview]
Message-ID: <20210830072913.fqq6n5rn3nkbpm3q@skbuf> (raw)
In-Reply-To: <20210828235619.249757-1-linus.walleij@linaro.org>
On Sun, Aug 29, 2021 at 01:56:19AM +0200, Linus Walleij wrote:
> I noticed that only port 0 worked on the RTL8366RB since we
> started to use custom tags.
>
> It turns out that the format of egress custom tags is actually
> different from ingress custom tags. While the lower bits just
> contain the port number in ingress tags, egress tags need to
> indicate destination port by setting the bit for the
> corresponding port.
>
> It was working on port 0 because port 0 added 0x00 as port
> number in the lower bits, and if you do this the packet gets
> broadcasted to all ports, including the intended port.
> Ooops.
Does it get broadcast, or forwarded by MAC DA/VLAN ID as you'd expect
for a regular data packet?
>
> Fix this and all ports work again.
>
> Tested on the D-Link DIR-685 by sending traffic to each of
> the ports in turn. It works.
>
> Fixes: 86dd9868b878 ("net: dsa: tag_rtl4_a: Support also egress tags")
> Cc: DENG Qingfang <dqfext@gmail.com>
> Cc: Mauri Sandberg <sandberg@mailfence.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> net/dsa/tag_rtl4_a.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/net/dsa/tag_rtl4_a.c b/net/dsa/tag_rtl4_a.c
> index 57c46b4ab2b3..042a6cb7704a 100644
> --- a/net/dsa/tag_rtl4_a.c
> +++ b/net/dsa/tag_rtl4_a.c
> @@ -54,9 +54,10 @@ static struct sk_buff *rtl4a_tag_xmit(struct sk_buff *skb,
> p = (__be16 *)tag;
> *p = htons(RTL4_A_ETHERTYPE);
>
> - out = (RTL4_A_PROTOCOL_RTL8366RB << 12) | (2 << 8);
What was 2 << 8? This patch changes that part.
> - /* The lower bits is the port number */
> - out |= (u8)dp->index;
> + out = (RTL4_A_PROTOCOL_RTL8366RB << RTL4_A_PROTOCOL_SHIFT);
> + /* The lower bits indicate the port number */
> + out |= BIT(dp->index);
> +
> p = (__be16 *)(tag + 2);
> *p = htons(out);
>
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-08-30 7:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 23:56 [PATCH net] net: dsa: tag_rtl4_a: Fix egress tags Linus Walleij
2021-08-30 7:29 ` Vladimir Oltean [this message]
2021-08-30 21:56 ` Linus Walleij
2021-08-30 22:20 ` Vladimir Oltean
2021-08-31 18:35 ` Linus Walleij
2021-08-31 19:05 ` Vladimir Oltean
-- strict thread matches above, loose matches on Subject: below --
2021-02-28 17:08 [PATCH net] net: dsa: tag_rtl4_a: fix " DENG Qingfang
2021-02-28 17:54 ` Florian Fainelli
2021-03-01 13:58 ` Linus Walleij
2021-03-01 14:01 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830072913.fqq6n5rn3nkbpm3q@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=sandberg@mailfence.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).