From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: "trix@redhat.com" <trix@redhat.com>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"nathan@kernel.org" <nathan@kernel.org>,
"ndesaulniers@google.com" <ndesaulniers@google.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>
Subject: Re: [PATCH] net: mscc: ocelot: fix using match before it is set
Date: Thu, 20 Jan 2022 17:08:53 +0000 [thread overview]
Message-ID: <20220120170852.d2iwgagxcu2eajj2@skbuf> (raw)
In-Reply-To: <20220118134110.591613-1-trix@redhat.com>
On Tue, Jan 18, 2022 at 05:41:10AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Clang static analysis reports this issue
> ocelot_flower.c:563:8: warning: 1st function call argument
> is an uninitialized value
> !is_zero_ether_addr(match.mask->dst)) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> The variable match is used before it is set. So move the
> block.
>
> Fixes: 75944fda1dfe ("net: mscc: ocelot: offload ingress skbedit and vlan actions to VCAP IS1")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
(sorry for the delay)
prev parent reply other threads:[~2022-01-20 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 13:41 [PATCH] net: mscc: ocelot: fix using match before it is set trix
2022-01-19 14:40 ` patchwork-bot+netdevbpf
2022-01-20 17:08 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120170852.d2iwgagxcu2eajj2@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=trix@redhat.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).