From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: "Ziyang Xuan (William)" <william.xuanziyang@huawei.com>,
davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] can: isotp: isotp_rcv_cf(): fix so->rx race problem
Date: Fri, 28 Jan 2022 09:07:04 +0100 [thread overview]
Message-ID: <20220128080704.ns5fzbyn72wfoqmx@pengutronix.de> (raw)
In-Reply-To: <24e6da96-a3e5-7b4e-102b-b5676770b80e@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]
On 28.01.2022 08:56:19, Oliver Hartkopp wrote:
> I've seen the frame processing sometimes freezes for one second when
> stressing the isotp_rcv() from multiple sources. This finally freezes
> the entire softirq which is either not good and not needed as we only
> need to fix this race for stress tests - and not for real world usage
> that does not create this case.
Hmmm, this doesn't sound good. Can you test with LOCKDEP enabled?
>
> Therefore I created a V2 patch which uses the spin_trylock() to simply drop
> the incomming frame in the race condition.
>
> https://lore.kernel.org/linux-can/20220128074327.52229-1-socketcan@hartkopp.net/T/
>
> Please take a look, if it also fixes the issue in your test setup.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-01-28 8:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 12:01 [PATCH net] can: isotp: isotp_rcv_cf(): fix so->rx race problem Ziyang Xuan
2022-01-18 7:58 ` Oliver Hartkopp
2022-01-18 12:46 ` Ziyang Xuan (William)
2022-01-18 14:44 ` Oliver Hartkopp
2022-01-20 6:24 ` Ziyang Xuan (William)
2022-01-20 8:23 ` Oliver Hartkopp
2022-01-20 11:28 ` Ziyang Xuan (William)
2022-01-20 14:46 ` Oliver Hartkopp
2022-01-21 1:50 ` Ziyang Xuan (William)
2022-01-27 19:44 ` Oliver Hartkopp
2022-01-28 7:56 ` Oliver Hartkopp
2022-01-28 8:07 ` Marc Kleine-Budde [this message]
2022-01-28 8:32 ` Oliver Hartkopp
2022-01-28 8:46 ` Marc Kleine-Budde
2022-01-28 14:48 ` Oliver Hartkopp
2022-02-07 8:11 ` Marc Kleine-Budde
2022-02-09 7:54 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128080704.ns5fzbyn72wfoqmx@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=william.xuanziyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).