netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: alexander.duyck@gmail.com, kuba@kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	chen45464546@163.com
Subject: Re: [PATCH V3] mm: prevent page_frag_alloc() from corrupting the memory
Date: Mon, 8 Aug 2022 17:14:52 -0700	[thread overview]
Message-ID: <20220808171452.d870753e1494b92ba2142116@linux-foundation.org> (raw)
In-Reply-To: <20220715125013.247085-1-mlombard@redhat.com>

On Fri, 15 Jul 2022 14:50:13 +0200 Maurizio Lombardi <mlombard@redhat.com> wrote:

> A number of drivers call page_frag_alloc() with a
> fragment's size > PAGE_SIZE.
> In low memory conditions, __page_frag_cache_refill() may fail the order 3
> cache allocation and fall back to order 0;
> In this case, the cache will be smaller than the fragment, causing
> memory corruptions.
> 
> Prevent this from happening by checking if the newly allocated cache
> is large enough for the fragment; if not, the allocation will fail
> and page_frag_alloc() will return NULL.

Can we come up with a Fixes: for this?

Should this fix be backported into -stable kernels?

  parent reply	other threads:[~2022-08-09  0:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-15 12:50 [PATCH V3] mm: prevent page_frag_alloc() from corrupting the memory Maurizio Lombardi
2022-07-18 13:14 ` Chen Lin
2022-07-18 13:50   ` [PATCH " Maurizio Lombardi
2022-07-18 14:40     ` Chen Lin
2022-07-18 15:25       ` Maurizio Lombardi
2022-07-18 15:33         ` Alexander Duyck
2022-07-19 22:27           ` Chen Lin
2022-07-20 14:54             ` Alexander Duyck
2022-07-21 13:05               ` Chen Lin
     [not found] ` <62aacb46.a9b1.182110646cf.Coremail.chen45464546@163.com>
2022-07-18 13:46   ` Maurizio Lombardi
2022-08-09  0:14 ` Andrew Morton [this message]
2022-08-09 11:45   ` Maurizio Lombardi
2022-08-09 14:33     ` Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220808171452.d870753e1494b92ba2142116@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=alexander.duyck@gmail.com \
    --cc=chen45464546@163.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mlombard@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).