netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Michal Kubecek <mkubecek@suse.cz>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH net-next 0/2] ethtool mm API improvements
Date: Sat, 15 Apr 2023 20:34:52 +0300	[thread overview]
Message-ID: <20230415173454.3970647-1-vladimir.oltean@nxp.com> (raw)

Currently the ethtool --set-mm API permits the existence of 2
configurations which don't make sense:

- pmac-enabled false tx-enabled true
- tx-enabled false verify-enabled true

By rejecting these, we can give driver-level code more guarantees.
I re-ran the MM selftest posted here (which I need to repost):
https://lore.kernel.org/netdev/20230210221243.228932-1-vladimir.oltean@nxp.com/

and it didn't cause functional problems.

Vladimir Oltean (2):
  net: enetc: fix MAC Merge layer remaining enabled until a link down
    event
  net: ethtool: mm: sanitize some UAPI configurations

 drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 11 +++++++----
 net/ethtool/mm.c                                     |  5 +++++
 2 files changed, 12 insertions(+), 4 deletions(-)

-- 
2.34.1


             reply	other threads:[~2023-04-15 17:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-15 17:34 Vladimir Oltean [this message]
2023-04-15 17:34 ` [PATCH net-next 1/2] net: enetc: fix MAC Merge layer remaining enabled until a link down event Vladimir Oltean
2023-04-15 17:34 ` [PATCH net-next 2/2] net: ethtool: mm: sanitize some UAPI configurations Vladimir Oltean
2023-04-15 18:09 ` [PATCH net-next 0/2] ethtool mm API improvements Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230415173454.3970647-1-vladimir.oltean@nxp.com \
    --to=vladimir.oltean@nxp.com \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=xiaoliang.yang_1@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).