From: Stephen Hemminger <stephen@networkplumber.org>
To: Chuck Lever <cel@kernel.org>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
BMT@zurich.ibm.com, tom@talpey.com
Subject: Re: [PATCH RFC 2/3] net/lo: Ensure lo devices have a MAC address
Date: Fri, 5 May 2023 09:57:17 -0700 [thread overview]
Message-ID: <20230505095717.6ad2b4ca@hermes.local> (raw)
In-Reply-To: <168330135435.5953.3471584034284499194.stgit@oracle-102.nfsv4bat.org>
On Fri, 05 May 2023 11:42:44 -0400
Chuck Lever <cel@kernel.org> wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> A non-zero MAC address enables a network device to be assigned as
> the underlying device for a virtual RDMA device. Without a non-
> zero MAC address, cma_acquire_dev_by_src_ip() is unable to find the
> underlying egress device that corresponds to a source IP address,
> and rdma_resolve_address() fails.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> drivers/net/loopback.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
> index f6d53e63ef4e..1ce4f19d8065 100644
> --- a/drivers/net/loopback.c
> +++ b/drivers/net/loopback.c
> @@ -192,6 +192,8 @@ static void gen_lo_setup(struct net_device *dev,
> dev->needs_free_netdev = true;
> dev->priv_destructor = dev_destructor;
>
> + eth_hw_addr_random(dev);
> +
> netif_set_tso_max_size(dev, GSO_MAX_SIZE);
> }
>
>
>
>
This enough of a change, it will probably break somebody.
If you need dummy endpoint (ie multiple loopback), a common way
is to use dummy devices for that.
next prev parent reply other threads:[~2023-05-05 16:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 15:41 [PATCH RFC 0/3] siw on tunnel devices Chuck Lever
2023-05-05 15:42 ` [PATCH RFC 1/3] net/tun: Ensure tun devices have a MAC address Chuck Lever
2023-05-05 16:59 ` Stephen Hemminger
2023-05-05 17:09 ` Chuck Lever III
2023-05-05 15:42 ` [PATCH RFC 2/3] net/lo: Ensure lo " Chuck Lever
2023-05-05 16:57 ` Stephen Hemminger [this message]
2023-05-05 15:43 ` [PATCH RFC 3/3] RDMA/siw: Require non-zero 6-byte MACs for soft iWARP Chuck Lever
2023-05-05 19:58 ` Jason Gunthorpe
2023-05-05 20:03 ` Chuck Lever III
2023-05-06 18:05 ` Chuck Lever III
2023-05-23 19:18 ` Chuck Lever III
2023-05-23 19:44 ` Tom Talpey
2023-05-23 22:50 ` Chuck Lever III
2023-05-31 19:04 ` Jason Gunthorpe
2023-05-31 19:11 ` Chuck Lever III
2023-05-31 20:09 ` Jason Gunthorpe
2023-05-31 20:19 ` Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230505095717.6ad2b4ca@hermes.local \
--to=stephen@networkplumber.org \
--cc=BMT@zurich.ibm.com \
--cc=cel@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).