netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <ye.xingchen@zte.com.cn>
To: <davem@davemloft.net>
Cc: <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] net: socket: Use fdget() and fdput()
Date: Fri, 5 May 2023 17:06:41 +0800 (CST)	[thread overview]
Message-ID: <202305051706416319733@zte.com.cn> (raw)

From: Ye Xingchen <ye.xingchen@zte.com.cn>

By using the fdget function, the socket object, can be quickly obtained
from the process's file descriptor table without the need to obtain the
file descriptor first before passing it as a parameter to the fget
function.

Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
 net/socket.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/net/socket.c b/net/socket.c
index a7b4b37d86df..84daba774432 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -528,19 +528,18 @@ EXPORT_SYMBOL(sock_from_file);

 struct socket *sockfd_lookup(int fd, int *err)
 {
-	struct file *file;
+	struct fd f = fdget(fd);
 	struct socket *sock;

-	file = fget(fd);
-	if (!file) {
+	if (!f.file) {
 		*err = -EBADF;
 		return NULL;
 	}

-	sock = sock_from_file(file);
+	sock = sock_from_file(f.file);
 	if (!sock) {
 		*err = -ENOTSOCK;
-		fput(file);
+		fdput(f);
 	}
 	return sock;
 }
-- 
2.25.1

             reply	other threads:[~2023-05-05  9:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05  9:06 ye.xingchen [this message]
2023-05-05 10:37 ` [PATCH] net: socket: Use fdget() and fdput() Eric Dumazet
2023-05-11  5:24 ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202305051706416319733@zte.com.cn \
    --to=ye.xingchen@zte.com.cn \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).