Re: [PATCH net-next] nfc: Switch i2c drivers back to use .probe() - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jean Delvare <jdelvare@suse.de>
Cc: "Corey Minyard" <cminyard@mvista.com>,
	"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
	"Peter Senna Tschudin" <peter.senna@gmail.com>,
	"Sebastian Reichel" <sebastian.reichel@collabora.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Jeremy Kerr" <jk@codeconstruct.com.au>,
	"Marek Behún" <kabel@kernel.org>, "Rob Herring" <robh@kernel.org>,
	"Javier Martinez Canillas" <javierm@redhat.com>,
	"Adrien Grassein" <adrien.grassein@gmail.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
	"Kang Chen" <void0red@gmail.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Petr Machata" <petrm@nvidia.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Shang XiaoJing" <shangxiaojing@huawei.com>,
	"Michael Walle" <michael@walle.cc>,
	kernel@pengutronix.de, netdev@vger.kernel.org,
	"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next] nfc: Switch i2c drivers back to use .probe()
Date: Wed, 24 May 2023 14:44:14 +0200	[thread overview]
Message-ID: <20230524124414.foiodqo6zejby27y@pengutronix.de> (raw)
In-Reply-To: <20230524131011.0d948017@endymion.delvare>

[-- Attachment #1: Type: text/plain, Size: 2071 bytes --]

Hello Jean,

On Wed, May 24, 2023 at 01:10:11PM +0200, Jean Delvare wrote:
> On Sat, 20 May 2023 19:21:04 +0200, Uwe Kleine-König wrote:
> > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> > call-back type"), all drivers being converted to .probe_new() and then
> > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> > convert back to (the new) .probe() to be able to eventually drop
> > .probe_new() from struct i2c_driver.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > Hello,
> > 
> > this patch was generated using coccinelle, but I aligned the result to
> > the per-file indention.
> > 
> > This is one patch for the whole iio subsystem. if you want it split per
> 
> s/iio/nfc/

Yeah, copy&paste failure. I noticed after sending out the patch, but as
it's only in a part of the mail that doesn't make it into git I didn't
care to point it out.

> > driver for improved patch count numbers, please tell me.
> > 
> > This currently fits on top of 6.4-rc1 and next/master. If you apply it
> > somewhere else and get conflicts, feel free to just drop the files with
> > conflicts from this patch and apply anyhow. I'll care about the fallout
> > later then.
> > 
> > Best regards
> > Uwe
> > 
> >  drivers/nfc/fdp/i2c.c       | 2 +-
> >  drivers/nfc/microread/i2c.c | 2 +-
> >  drivers/nfc/nfcmrvl/i2c.c   | 2 +-
> >  drivers/nfc/nxp-nci/i2c.c   | 2 +-
> >  drivers/nfc/pn533/i2c.c     | 2 +-
> >  drivers/nfc/pn544/i2c.c     | 2 +-
> >  drivers/nfc/s3fwrn5/i2c.c   | 2 +-
> >  drivers/nfc/st-nci/i2c.c    | 2 +-
> >  drivers/nfc/st21nfca/i2c.c  | 2 +-
> >  9 files changed, 9 insertions(+), 9 deletions(-)
> > (...)
> 
> Reviewed-by: Jean Delvare <jdelvare@suse.de>

Thanks, but note that davem already applied the patch, so your tag
probably won't make it in.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]