From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
sdf@google.com, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 00/12] tools: ynl: generate code for the ethtool family
Date: Fri, 9 Jun 2023 14:43:34 -0700 [thread overview]
Message-ID: <20230609214346.1605106-1-kuba@kernel.org> (raw)
And finally ethtool support. Thanks to Stan's work the ethtool family
spec is quite complete, so there is a lot of operations to support.
I chickened out of stats-get support, they require at the very least
type-value support on a u64 scalar. Type-value is an arrangement where
a u16 attribute is encoded directly in attribute type. Code gen can
support this if the inside is a nest, we just throw in an extra
field into that nest to carry the attr type. But a little more coding
is needed to for a scalar, because first we need to turn the scalar
into a struct with one member, then we can add the attr type.
Other than that ethtool required event support (notification which
does not share contents with any GET), but the previous series
already added that to the codegen.
I haven't tested all the ops here, and a few I tried seem to work.
Jakub Kicinski (12):
tools: ynl-gen: support excluding tricky ops
tools: ynl-gen: record extra args for regen
netlink: specs: support setting prefix-name per attribute
netlink: specs: ethtool: add C render hints
tools: ynl-gen: don't generate enum types if unnamed
tools: ynl-gen: resolve enum vs struct name conflicts
netlink: specs: ethtool: add empty enum stringset
netlink: specs: ethtool: untangle UDP tunnels and cable test a bit
netlink: specs: ethtool: untangle stats-get
netlink: specs: ethtool: mark pads as pads
tools: ynl: generate code for the ethtool family
tools: ynl: add sample for ethtool
Documentation/netlink/genetlink-c.yaml | 4 +
Documentation/netlink/genetlink-legacy.yaml | 4 +
Documentation/netlink/specs/ethtool.yaml | 120 +-
tools/net/ynl/generated/Makefile | 9 +-
tools/net/ynl/generated/ethtool-user.c | 6353 +++++++++++++++++++
tools/net/ynl/generated/ethtool-user.h | 5531 ++++++++++++++++
tools/net/ynl/lib/nlspec.py | 12 +-
tools/net/ynl/samples/.gitignore | 1 +
tools/net/ynl/samples/ethtool.c | 65 +
tools/net/ynl/ynl-gen-c.py | 59 +-
tools/net/ynl/ynl-regen.sh | 4 +-
11 files changed, 12116 insertions(+), 46 deletions(-)
create mode 100644 tools/net/ynl/generated/ethtool-user.c
create mode 100644 tools/net/ynl/generated/ethtool-user.h
create mode 100644 tools/net/ynl/samples/ethtool.c
--
2.40.1
next reply other threads:[~2023-06-09 21:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 21:43 Jakub Kicinski [this message]
2023-06-09 21:43 ` [PATCH net-next 01/12] tools: ynl-gen: support excluding tricky ops Jakub Kicinski
2023-06-09 21:43 ` [PATCH net-next 02/12] tools: ynl-gen: record extra args for regen Jakub Kicinski
2023-06-09 21:43 ` [PATCH net-next 03/12] netlink: specs: support setting prefix-name per attribute Jakub Kicinski
2023-06-09 21:43 ` [PATCH net-next 04/12] netlink: specs: ethtool: add C render hints Jakub Kicinski
2023-06-09 21:43 ` [PATCH net-next 05/12] tools: ynl-gen: don't generate enum types if unnamed Jakub Kicinski
2023-06-09 21:43 ` [PATCH net-next 06/12] tools: ynl-gen: resolve enum vs struct name conflicts Jakub Kicinski
2023-06-09 21:43 ` [PATCH net-next 07/12] netlink: specs: ethtool: add empty enum stringset Jakub Kicinski
2023-06-09 21:43 ` [PATCH net-next 08/12] netlink: specs: ethtool: untangle UDP tunnels and cable test a bit Jakub Kicinski
2023-06-09 21:43 ` [PATCH net-next 09/12] netlink: specs: ethtool: untangle stats-get Jakub Kicinski
2023-06-09 21:43 ` [PATCH net-next 10/12] netlink: specs: ethtool: mark pads as pads Jakub Kicinski
2023-06-09 21:43 ` [PATCH net-next 11/12] tools: ynl: generate code for the ethtool family Jakub Kicinski
2023-06-09 21:43 ` [PATCH net-next 12/12] tools: ynl: add sample for ethtool Jakub Kicinski
2023-06-09 22:12 ` [PATCH net-next 00/12] tools: ynl: generate code for the ethtool family Stanislav Fomichev
2023-06-12 10:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609214346.1605106-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).