From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
dsahern@gmail.com, mkubecek@suse.cz,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 0/2] net: support extack in dump and simplify ethtool uAPI
Date: Fri, 9 Jun 2023 14:53:29 -0700 [thread overview]
Message-ID: <20230609215331.1606292-1-kuba@kernel.org> (raw)
Ethtool currently requires header nest to be always present even if
it doesn't have to carry any attr for a given request. This inflicts
unnecessary pain on the users.
What makes it worse is that extack was not working in dump's ->start()
callback. Address both of those issues.
Jakub Kicinski (2):
netlink: support extack in dump ->start()
net: ethtool: don't require empty header nests
include/linux/netlink.h | 1 +
net/ethtool/netlink.c | 2 ++
net/netlink/af_netlink.c | 2 ++
net/netlink/genetlink.c | 2 ++
4 files changed, 7 insertions(+)
--
2.40.1
next reply other threads:[~2023-06-09 21:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 21:53 Jakub Kicinski [this message]
2023-06-09 21:53 ` [PATCH net-next 1/2] netlink: support extack in dump ->start() Jakub Kicinski
2023-06-09 21:53 ` [PATCH net-next 2/2] net: ethtool: don't require empty header nests Jakub Kicinski
2023-06-12 10:40 ` [PATCH net-next 0/2] net: support extack in dump and simplify ethtool uAPI patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609215331.1606292-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).