From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org, pavan.kumar.linga@intel.com,
emil.s.tantilov@intel.com, jesse.brandeburg@intel.com,
sridhar.samudrala@intel.com, shiraz.saleem@intel.com,
sindhu.devale@intel.com, willemb@google.com, decot@google.com,
andrew@lunn.ch, leon@kernel.org, mst@redhat.com,
simon.horman@corigine.com, shannon.nelson@amd.com,
stephen@networkplumber.org
Subject: Re: [PATCH net-next v3 00/15][pull request] Introduce Intel IDPF driver
Date: Fri, 16 Jun 2023 23:56:51 -0700 [thread overview]
Message-ID: <20230616235651.58b9519c@kernel.org> (raw)
In-Reply-To: <20230616231341.2885622-1-anthony.l.nguyen@intel.com>
On Fri, 16 Jun 2023 16:13:26 -0700 Tony Nguyen wrote:
> v3:
> Patch 5:
> * instead of void, used 'struct virtchnl2_create_vport' type for
> vport_params_recvd and vport_params_reqd and removed the typecasting
> * used u16/u32 as needed instead of int for variables which cannot be
> negative and updated in all the places whereever applicable
> Patch 6:
> * changed the commit message to "add ptypes and MAC filter support"
> * used the sender Signed-off-by as the last tag on all the patches
> * removed unnecessary variables 0-init
> * instead of fixing the code in this commit, fixed it in the commit
> where the change was introduced first
> * moved get_type_info struct on to the stack instead of memory alloc
> * moved mutex_lock and ptype_info memory alloc outside while loop and
> adjusted the return flow
> * used 'break' instead of 'continue' in ptype id switch case
Ah, missed this, busy times.
Luckily I commented on different patches than the ones that changed.
--
pw-bot: cr
next prev parent reply other threads:[~2023-06-17 6:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 23:13 [PATCH net-next v3 00/15][pull request] Introduce Intel IDPF driver Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 01/15] virtchnl: add virtchnl version 2 ops Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 02/15] idpf: add module register and probe functionality Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 03/15] idpf: add controlq init and reset checks Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 04/15] idpf: add core init and interrupt request Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 05/15] idpf: add create vport and netdev configuration Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 06/15] idpf: add ptypes and MAC filter support Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 07/15] idpf: configure resources for TX queues Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 08/15] idpf: configure resources for RX queues Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 09/15] idpf: initialize interrupts and enable vport Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 10/15] idpf: add splitq start_xmit Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 11/15] idpf: add TX splitq napi poll support Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 12/15] idpf: add RX " Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 13/15] idpf: add singleq start_xmit and napi poll Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 14/15] idpf: add ethtool callbacks Tony Nguyen
2023-06-16 23:13 ` [PATCH net-next v3 15/15] idpf: configure SRIOV and add other ndo_ops Tony Nguyen
2023-06-17 6:56 ` Jakub Kicinski [this message]
2023-06-21 19:13 ` [PATCH net-next v3 00/15][pull request] Introduce Intel IDPF driver Linga, Pavan Kumar
2023-06-21 19:28 ` Jakub Kicinski
2023-06-21 19:44 ` Andrew Lunn
2023-06-21 20:19 ` David Decotigny
2023-06-21 20:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616235651.58b9519c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=edumazet@google.com \
--cc=emil.s.tantilov@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=leon@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.kumar.linga@intel.com \
--cc=shannon.nelson@amd.com \
--cc=shiraz.saleem@intel.com \
--cc=simon.horman@corigine.com \
--cc=sindhu.devale@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=stephen@networkplumber.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).