From: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
To: Stefan Hajnoczi <stefanha@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Bobby Eshleman <bobby.eshleman@bytedance.com>
Cc: <kvm@vger.kernel.org>,
<virtualization@lists.linux-foundation.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@sberdevices.ru>, <oxffffaa@gmail.com>,
<avkrasnov@sberdevices.ru>,
Arseniy Krasnov <AVKrasnov@sberdevices.ru>
Subject: [RFC PATCH v5 08/17] vsock: check for MSG_ZEROCOPY support on send
Date: Sat, 1 Jul 2023 09:39:38 +0300 [thread overview]
Message-ID: <20230701063947.3422088-9-AVKrasnov@sberdevices.ru> (raw)
In-Reply-To: <20230701063947.3422088-1-AVKrasnov@sberdevices.ru>
This feature totally depends on transport, so if transport doesn't
support it, return error.
Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
---
include/net/af_vsock.h | 7 +++++++
net/vmw_vsock/af_vsock.c | 6 ++++++
2 files changed, 13 insertions(+)
diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h
index 0e7504a42925..ec09edc5f3a0 100644
--- a/include/net/af_vsock.h
+++ b/include/net/af_vsock.h
@@ -177,6 +177,9 @@ struct vsock_transport {
/* Read a single skb */
int (*read_skb)(struct vsock_sock *, skb_read_actor_t);
+
+ /* Zero-copy. */
+ bool (*msgzerocopy_allow)(void);
};
/**** CORE ****/
@@ -243,4 +246,8 @@ static inline void __init vsock_bpf_build_proto(void)
{}
#endif
+static inline bool vsock_msgzerocopy_allow(const struct vsock_transport *t)
+{
+ return t->msgzerocopy_allow && t->msgzerocopy_allow();
+}
#endif /* __AF_VSOCK_H__ */
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 07803d9fbf6d..033006e1b5ad 100644
--- a/net/vmw_vsock/af_vsock.c
+++ b/net/vmw_vsock/af_vsock.c
@@ -1824,6 +1824,12 @@ static int vsock_connectible_sendmsg(struct socket *sock, struct msghdr *msg,
goto out;
}
+ if (msg->msg_flags & MSG_ZEROCOPY &&
+ !vsock_msgzerocopy_allow(transport)) {
+ err = -EOPNOTSUPP;
+ goto out;
+ }
+
/* Wait for room in the produce queue to enqueue our user's data. */
timeout = sock_sndtimeo(sk, msg->msg_flags & MSG_DONTWAIT);
--
2.25.1
next prev parent reply other threads:[~2023-07-01 6:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-01 6:39 [RFC PATCH v5 00/17] vsock: MSG_ZEROCOPY flag support Arseniy Krasnov
2023-07-01 6:39 ` [RFC PATCH v5 01/17] vsock/virtio: read data from non-linear skb Arseniy Krasnov
2023-07-06 16:47 ` Stefano Garzarella
2023-07-01 6:39 ` [RFC PATCH v5 02/17] vhost/vsock: " Arseniy Krasnov
2023-07-06 16:49 ` Stefano Garzarella
2023-07-01 6:39 ` [RFC PATCH v5 03/17] vsock/virtio: support to send " Arseniy Krasnov
2023-07-06 16:51 ` Stefano Garzarella
2023-07-01 6:39 ` [RFC PATCH v5 04/17] vsock/virtio: non-linear skb handling for tap Arseniy Krasnov
2023-07-06 16:51 ` Stefano Garzarella
2023-07-01 6:39 ` [RFC PATCH v5 05/17] vsock/virtio: MSG_ZEROCOPY flag support Arseniy Krasnov
2023-07-06 16:53 ` Stefano Garzarella
2023-07-01 6:39 ` [RFC PATCH v5 06/17] vsock: fix EPOLLERR set on non-empty error queue Arseniy Krasnov
2023-07-06 16:54 ` Stefano Garzarella
2023-07-01 6:39 ` [RFC PATCH v5 07/17] vsock: read from socket's " Arseniy Krasnov
2023-07-06 16:54 ` Stefano Garzarella
2023-07-01 6:39 ` Arseniy Krasnov [this message]
2023-07-06 16:55 ` [RFC PATCH v5 08/17] vsock: check for MSG_ZEROCOPY support on send Stefano Garzarella
2023-07-01 6:39 ` [RFC PATCH v5 09/17] vsock: enable SOCK_SUPPORT_ZC bit Arseniy Krasnov
2023-07-06 16:55 ` Stefano Garzarella
2023-07-01 6:39 ` [RFC PATCH v5 10/17] vhost/vsock: support MSG_ZEROCOPY for transport Arseniy Krasnov
2023-07-06 16:55 ` Stefano Garzarella
2023-07-01 6:39 ` [RFC PATCH v5 11/17] vsock/virtio: " Arseniy Krasnov
2023-07-06 16:55 ` Stefano Garzarella
2023-07-01 6:39 ` [RFC PATCH v5 12/17] vsock/loopback: " Arseniy Krasnov
2023-07-06 16:56 ` Stefano Garzarella
2023-07-01 6:39 ` [RFC PATCH v5 13/17] vsock: enable setting SO_ZEROCOPY Arseniy Krasnov
2023-07-06 16:56 ` Stefano Garzarella
2023-07-12 22:31 ` Bobby Eshleman
2023-07-13 4:37 ` Arseniy Krasnov
2023-07-01 6:39 ` [RFC PATCH v5 14/17] docs: net: description of MSG_ZEROCOPY for AF_VSOCK Arseniy Krasnov
2023-07-06 17:06 ` Stefano Garzarella
2023-07-07 4:45 ` Arseniy Krasnov
2023-07-01 6:39 ` [RFC PATCH v5 15/17] test/vsock: MSG_ZEROCOPY flag tests Arseniy Krasnov
2023-07-01 6:39 ` [RFC PATCH v5 16/17] test/vsock: MSG_ZEROCOPY support for vsock_perf Arseniy Krasnov
2023-07-01 6:39 ` [RFC PATCH v5 17/17] test/vsock: io_uring rx/tx tests Arseniy Krasnov
2023-07-06 17:06 ` Stefano Garzarella
2023-07-07 4:47 ` Arseniy Krasnov
2023-07-06 17:07 ` [RFC PATCH v5 00/17] vsock: MSG_ZEROCOPY flag support Stefano Garzarella
2023-07-07 4:41 ` Arseniy Krasnov
-- strict thread matches above, loose matches on Subject: below --
2023-07-01 6:22 Arseniy Krasnov
2023-07-01 6:23 ` [RFC PATCH v5 08/17] vsock: check for MSG_ZEROCOPY support on send Arseniy Krasnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230701063947.3422088-9-AVKrasnov@sberdevices.ru \
--to=avkrasnov@sberdevices.ru \
--cc=bobby.eshleman@bytedance.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kernel@sberdevices.ru \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oxffffaa@gmail.com \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).