From: Victor Nogueira <victor@mojatatu.com>
To: netdev@vger.kernel.org
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, pctammela@mojatatu.com, kernel@mojatatu.com
Subject: [PATCH net 0/5] net: sched: Undo tcf_bind_filter in case of errors in set callbacks
Date: Tue, 4 Jul 2023 12:14:51 -0300 [thread overview]
Message-ID: <20230704151456.52334-1-victor@mojatatu.com> (raw)
Five different classifier (fw, bpf, u32, matchall, and flower) are
calling tcf_bind_filter in their callbacks, but weren't undoing it by
calling tcf_unbind_filter if their was an error after binding.
This patch set fixes all this by calling tcf_unbind_filter in such
cases.
This set also undoes a refcount decrement in cls_u32 when an update
fails under specific conditions which are described in patch #4.
Victor Nogueira (5):
net: sched: cls_bpf: Undo tcf_bind_filter in case of an error
net: sched: cls_matchall: Undo tcf_bind_filter in case of failure
after mall_set_parms
net: sched: cls_u32: Undo tcf_bind_filter if u32_replace_hw_knode
net: sched: cls_u32: Undo refcount decrement in case update failed
net: sched: cls_flower: Undo tcf_bind_filter if fl_set_key fails
net/sched/cls_bpf.c | 8 ++++++--
net/sched/cls_flower.c | 29 +++++++++++++++++++++++++----
net/sched/cls_matchall.c | 8 ++++++--
net/sched/cls_u32.c | 32 ++++++++++++++++++++++++++------
4 files changed, 63 insertions(+), 14 deletions(-)
--
2.25.1
next reply other threads:[~2023-07-04 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 15:14 Victor Nogueira [this message]
2023-07-04 15:14 ` [PATCH net 1/5] net: sched: cls_bpf: Undo tcf_bind_filter in case of an error Victor Nogueira
2023-07-04 20:48 ` Simon Horman
2023-07-04 20:55 ` Jamal Hadi Salim
2023-07-04 21:19 ` Simon Horman
2023-07-04 21:42 ` Jamal Hadi Salim
2023-07-05 7:45 ` Simon Horman
2023-07-04 15:14 ` [PATCH net 2/5] net: sched: cls_matchall: Undo tcf_bind_filter in case of failure after mall_set_parms Victor Nogueira
2023-07-04 15:14 ` [PATCH net 3/5] net: sched: cls_u32: Undo tcf_bind_filter if u32_replace_hw_knode Victor Nogueira
2023-07-04 15:14 ` [PATCH net 4/5] net: sched: cls_u32: Undo refcount decrement in case update failed Victor Nogueira
2023-07-04 15:14 ` [PATCH net 5/5] net: sched: cls_flower: Undo tcf_bind_filter if fl_set_key fails Victor Nogueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704151456.52334-1-victor@mojatatu.com \
--to=victor@mojatatu.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).