From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Astra Joan <astrajoan@yahoo.com>
Cc: davem@davemloft.net, edumazet@google.com,
ivan.orlov0322@gmail.com, kernel@pengutronix.de, kuba@kernel.org,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@rempel-privat.de, mkl@pengutronix.de,
netdev@vger.kernel.org, pabeni@redhat.com, robin@protonic.nl,
skhan@linuxfoundation.org, socketcan@hartkopp.net,
syzbot+1591462f226d9cbf0564@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] can: j1939: prevent deadlock by changing j1939_socks_lock to rwlock
Date: Wed, 5 Jul 2023 06:39:55 +0200 [thread overview]
Message-ID: <20230705043955.GE15522@pengutronix.de> (raw)
In-Reply-To: <F17EC83C-9D70-463A-9C46-FBCC53A1F13C@yahoo.com>
On Tue, Jul 04, 2023 at 10:55:47AM -0700, Astra Joan wrote:
> Hi Oleksij,
>
> Thank you for providing help with the bug fix! The patch was created
> when I was working on another bug:
>
> https://syzkaller.appspot.com/bug?extid=881d65229ca4f9ae8c84
>
> But the patch was not a direct fix of the problem reported in the
> unregister_netdevice function call. Instead, it suppresses potential
> deadlock information to guarantee the real bug would show up. Since I
> have verified that the patch resolved a deadlock situation involving
> the exact same locks, I'm pretty confident it would be a proper fix for
> the current bug in this thread.
>
> I'm not sure, though, about how I could instruct Syzbot to create a
> reproducer to properly test this patch. Could you or anyone here help
> me find the next step? Thank you so much!
Sorry, I'm not syzbot expert. I hope someone else can help here.
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-07-05 4:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F17EC83C-9D70-463A-9C46-FBCC53A1F13C.ref@yahoo.com>
2023-07-04 17:55 ` [PATCH] can: j1939: prevent deadlock by changing j1939_socks_lock to rwlock Astra Joan
2023-07-05 4:39 ` Oleksij Rempel [this message]
2023-07-05 4:50 ` Dmitry Vyukov
[not found] <C29A816B-6E28-4A36-AE59-F446180C910B.ref@yahoo.com>
2023-07-14 5:58 ` Astra Joan
2023-07-10 17:53 [syzbot] [can?] possible deadlock in j1939_sk_errqueue (2) syzbot
2023-07-12 0:47 ` [PATCH] can: j1939: prevent deadlock by changing j1939_socks_lock to rwlock Ziqi Zhao
2023-07-13 22:23 ` Stephen Hemminger
[not found] <8A7EE4B2-4DCE-40FF-B971-F67F402872BB.ref@yahoo.com>
2023-07-07 4:39 ` Astra Joan
-- strict thread matches above, loose matches on Subject: below --
2023-07-04 6:19 [syzbot] [can?] possible deadlock in j1939_sk_errqueue (2) syzbot
2023-07-04 6:47 ` [PATCH] can: j1939: prevent deadlock by changing j1939_socks_lock to rwlock Ziqi Zhao
2023-07-04 6:47 ` syzbot
2023-07-04 7:37 ` Oleksij Rempel
2023-07-21 16:22 ` Ziqi Zhao
2023-07-23 15:41 ` Oleksij Rempel
2023-08-07 4:46 ` Oleksij Rempel
2023-11-17 8:10 ` Oleksij Rempel
2023-06-21 8:46 [syzbot] [net?] unregister_netdevice: waiting for DEV to become free (8) Dongliang Mu
2023-06-26 5:50 ` [PATCH] can: j1939: prevent deadlock by changing j1939_socks_lock to rwlock Ziqi Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705043955.GE15522@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=astrajoan@yahoo.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ivan.orlov0322@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robin@protonic.nl \
--cc=skhan@linuxfoundation.org \
--cc=socketcan@hartkopp.net \
--cc=syzbot+1591462f226d9cbf0564@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).