From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Arseniy Krasnov <avkrasnov@sberdevices.ru>,
Stefan Hajnoczi <stefanha@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Bobby Eshleman <bobby.eshleman@bytedance.com>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@sberdevices.ru, oxffffaa@gmail.com
Subject: Re: [PATCH net-next v3 4/4] vsock/virtio: MSG_ZEROCOPY flag support
Date: Tue, 25 Jul 2023 09:06:02 -0400 [thread overview]
Message-ID: <20230725090514-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <mul7yiwl2pspfegeanqyezhmw6ol4cxsdshch7ln6w3i2b54bw@7na6bf5kfxwy>
On Tue, Jul 25, 2023 at 02:53:39PM +0200, Stefano Garzarella wrote:
> On Tue, Jul 25, 2023 at 07:50:53AM -0400, Michael S. Tsirkin wrote:
> > On Fri, Jul 21, 2023 at 08:09:03AM +0300, Arseniy Krasnov wrote:
> > >
> > >
> > > On 21.07.2023 00:42, Arseniy Krasnov wrote:
> > > > This adds handling of MSG_ZEROCOPY flag on transmission path: if this
> > > > flag is set and zerocopy transmission is possible (enabled in socket
> > > > options and transport allows zerocopy), then non-linear skb will be
> > > > created and filled with the pages of user's buffer. Pages of user's
> > > > buffer are locked in memory by 'get_user_pages()'. Second thing that
> > > > this patch does is replace type of skb owning: instead of calling
> > > > 'skb_set_owner_sk_safe()' it calls 'skb_set_owner_w()'. Reason of this
> > > > change is that '__zerocopy_sg_from_iter()' increments 'sk_wmem_alloc'
> > > > of socket, so to decrease this field correctly proper skb destructor is
> > > > needed: 'sock_wfree()'. This destructor is set by 'skb_set_owner_w()'.
> > > >
> > > > Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> > > > ---
> > > > Changelog:
> > > > v5(big patchset) -> v1:
> > > > * Refactorings of 'if' conditions.
> > > > * Remove extra blank line.
> > > > * Remove 'frag_off' field unneeded init.
> > > > * Add function 'virtio_transport_fill_skb()' which fills both linear
> > > > and non-linear skb with provided data.
> > > > v1 -> v2:
> > > > * Use original order of last four arguments in 'virtio_transport_alloc_skb()'.
> > > > v2 -> v3:
> > > > * Add new transport callback: 'msgzerocopy_check_iov'. It checks that
> > > > provided 'iov_iter' with data could be sent in a zerocopy mode.
> > > > If this callback is not set in transport - transport allows to send
> > > > any 'iov_iter' in zerocopy mode. Otherwise - if callback returns 'true'
> > > > then zerocopy is allowed. Reason of this callback is that in case of
> > > > G2H transmission we insert whole skb to the tx virtio queue and such
> > > > skb must fit to the size of the virtio queue to be sent in a single
> > > > iteration (may be tx logic in 'virtio_transport.c' could be reworked
> > > > as in vhost to support partial send of current skb). This callback
> > > > will be enabled only for G2H path. For details pls see comment
> > > > 'Check that tx queue...' below.
> > > >
> > > > include/net/af_vsock.h | 3 +
> > > > net/vmw_vsock/virtio_transport.c | 39 ++++
> > > > net/vmw_vsock/virtio_transport_common.c | 257 ++++++++++++++++++------
> > > > 3 files changed, 241 insertions(+), 58 deletions(-)
> > > >
> > > > diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h
> > > > index 0e7504a42925..a6b346eeeb8e 100644
> > > > --- a/include/net/af_vsock.h
> > > > +++ b/include/net/af_vsock.h
> > > > @@ -177,6 +177,9 @@ struct vsock_transport {
> > > >
> > > > /* Read a single skb */
> > > > int (*read_skb)(struct vsock_sock *, skb_read_actor_t);
> > > > +
> > > > + /* Zero-copy. */
> > > > + bool (*msgzerocopy_check_iov)(const struct iov_iter *);
> > > > };
> > > >
> > > > /**** CORE ****/
> > > > diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
> > > > index 7bbcc8093e51..23cb8ed638c4 100644
> > > > --- a/net/vmw_vsock/virtio_transport.c
> > > > +++ b/net/vmw_vsock/virtio_transport.c
> > > > @@ -442,6 +442,43 @@ static void virtio_vsock_rx_done(struct virtqueue *vq)
> > > > queue_work(virtio_vsock_workqueue, &vsock->rx_work);
> > > > }
> > > >
> > > > +static bool virtio_transport_msgzerocopy_check_iov(const struct iov_iter *iov)
> > > > +{
> > > > + struct virtio_vsock *vsock;
> > > > + bool res = false;
> > > > +
> > > > + rcu_read_lock();
> > > > +
> > > > + vsock = rcu_dereference(the_virtio_vsock);
> > > > + if (vsock) {
> > > > + struct virtqueue *vq;
> > > > + int iov_pages;
> > > > +
> > > > + vq = vsock->vqs[VSOCK_VQ_TX];
> > > > +
> > > > + iov_pages = round_up(iov->count, PAGE_SIZE) / PAGE_SIZE;
> > > > +
> > > > + /* Check that tx queue is large enough to keep whole
> > > > + * data to send. This is needed, because when there is
> > > > + * not enough free space in the queue, current skb to
> > > > + * send will be reinserted to the head of tx list of
> > > > + * the socket to retry transmission later, so if skb
> > > > + * is bigger than whole queue, it will be reinserted
> > > > + * again and again, thus blocking other skbs to be sent.
> > > > + * Each page of the user provided buffer will be added
> > > > + * as a single buffer to the tx virtqueue, so compare
> > > > + * number of pages against maximum capacity of the queue.
> > > > + * +1 means buffer for the packet header.
> > > > + */
> > > > + if (iov_pages + 1 <= vq->num_max)
> > >
> > > I think this check is actual only for case one we don't have indirect buffer feature.
> > > With indirect mode whole data to send will be packed into one indirect buffer.
> > >
> > > Thanks, Arseniy
> >
> > Actually the reverse. With indirect you are limited to num_max.
> > Without you are limited to whatever space is left in the
> > queue (which you did not check here, so you should).
> >
> >
> > > > + res = true;
> > > > + }
> > > > +
> > > > + rcu_read_unlock();
> >
> > Just curious:
> > is the point of all this RCU dance to allow vsock
> > to change from under us? then why is it ok to
> > have it change? the virtio_transport_msgzerocopy_check_iov
> > will then refer to the old vsock ...
>
> IIRC we introduced the RCU to handle hot-unplug issues:
> commit 0deab087b16a ("vsock/virtio: use RCU to avoid use-after-free on
> the_virtio_vsock")
>
> When we remove the device, we flush all the works, etc. so we should
> not be in this case (referring the old vsock), except for an irrelevant
> transient as the device is disappearing.
>
> Stefano
what if old device goes away then new one appears?
--
MST
next prev parent reply other threads:[~2023-07-25 13:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 21:42 [PATCH net-next v3 0/4] vsock/virtio/vhost: MSG_ZEROCOPY preparations Arseniy Krasnov
2023-07-20 21:42 ` [PATCH net-next v3 1/4] vsock/virtio/vhost: read data from non-linear skb Arseniy Krasnov
2023-07-20 21:42 ` [PATCH net-next v3 2/4] vsock/virtio: support to send " Arseniy Krasnov
2023-07-25 8:17 ` Stefano Garzarella
2023-07-20 21:42 ` [PATCH net-next v3 3/4] vsock/virtio: non-linear skb handling for tap Arseniy Krasnov
2023-07-20 21:42 ` [PATCH net-next v3 4/4] vsock/virtio: MSG_ZEROCOPY flag support Arseniy Krasnov
2023-07-21 5:09 ` Arseniy Krasnov
2023-07-25 8:43 ` Stefano Garzarella
2023-07-25 8:46 ` Arseniy Krasnov
2023-07-25 9:16 ` Arseniy Krasnov
2023-07-25 12:28 ` Stefano Garzarella
2023-07-25 12:39 ` Michael S. Tsirkin
2023-07-25 12:45 ` Stefano Garzarella
2023-07-27 8:32 ` Arseniy Krasnov
2023-07-27 8:54 ` Stefano Garzarella
2023-07-25 11:50 ` Michael S. Tsirkin
2023-07-25 12:53 ` Stefano Garzarella
2023-07-25 13:06 ` Michael S. Tsirkin [this message]
2023-07-25 13:21 ` Stefano Garzarella
2023-07-25 13:04 ` Arseniy Krasnov
2023-07-25 13:22 ` Michael S. Tsirkin
2023-07-25 13:28 ` Arseniy Krasnov
2023-07-25 13:36 ` Michael S. Tsirkin
2023-07-25 13:35 ` Arseniy Krasnov
2023-07-25 8:25 ` Michael S. Tsirkin
2023-07-25 8:39 ` Arseniy Krasnov
2023-07-25 11:59 ` Michael S. Tsirkin
2023-07-25 13:10 ` Arseniy Krasnov
2023-07-25 13:23 ` Michael S. Tsirkin
2023-07-25 13:30 ` Arseniy Krasnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725090514-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=avkrasnov@sberdevices.ru \
--cc=bobby.eshleman@bytedance.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kernel@sberdevices.ru \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oxffffaa@gmail.com \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).