From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Stefan Schmidt <stefan@datenfreihafen.org>
Cc: Alexander Aring <alex.aring@gmail.com>,
linux-wpan@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, David Girault <david.girault@qorvo.com>,
Romuald Despres <romuald.despres@qorvo.com>,
Frederic Blain <frederic.blain@qorvo.com>,
Nicolas Schodet <nico@ni.fr.eu.org>,
Guilhem Imberton <guilhem.imberton@qorvo.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH wpan-next v2 07/11] mac802154: Handle association requests from peers
Date: Mon, 18 Sep 2023 09:36:59 +0200 [thread overview]
Message-ID: <20230918093659.6488891a@xps-13> (raw)
In-Reply-To: <7b9b1b97-7c02-06b3-7a84-db1f33784be3@datenfreihafen.org>
Hi Stefan,
> > +static int
> > +mac802154_send_association_resp_locked(struct ieee802154_sub_if_data *sdata,
> > + struct ieee802154_pan_device *target,
> > + struct ieee802154_assoc_resp_pl *assoc_resp_pl)
> > +{
> > + u64 teaddr = swab64((__force u64)target->extended_addr);
> > + struct ieee802154_association_resp_frame frame = {};
> > + struct ieee802154_local *local = sdata->local;
> > + struct wpan_dev *wpan_dev = &sdata->wpan_dev;
> > + struct sk_buff *skb;
> > + int ret;
> > +
> > + frame.mhr.fc.type = IEEE802154_FC_TYPE_MAC_CMD;
> > + frame.mhr.fc.security_enabled = 0;
> > + frame.mhr.fc.frame_pending = 0;
> > + frame.mhr.fc.ack_request = 1; /* We always expect an ack here */
> > + frame.mhr.fc.intra_pan = 1;
> > + frame.mhr.fc.dest_addr_mode = IEEE802154_EXTENDED_ADDRESSING;
> > + frame.mhr.fc.version = IEEE802154_2003_STD;
> > + frame.mhr.fc.source_addr_mode = IEEE802154_EXTENDED_ADDRESSING;
> > + frame.mhr.seq = 10;
>
> Where does the 10 come from and what is the meaning?
Good point, that is a leftover from my earlier WIP versions. A few lines
below this is overwritten by:
frame.mhr.seq = atomic_inc_return(&wpan_dev->dsn) & 0xFF;
I'll of course drop the `seq = 10` line.
Thanks,
Miquèl
next prev parent reply other threads:[~2023-09-18 7:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 17:04 [PATCH wpan-next v2 00/11] ieee802154: Associations between devices Miquel Raynal
2023-09-01 17:04 ` [PATCH wpan-next v2 01/11] ieee802154: Let PAN IDs be reset Miquel Raynal
2023-09-01 17:04 ` [PATCH wpan-next v2 02/11] ieee802154: Internal PAN management Miquel Raynal
2023-09-16 15:36 ` Stefan Schmidt
2023-09-17 11:50 ` Alexander Aring
2023-09-18 9:01 ` Miquel Raynal
2023-09-18 11:11 ` Alexander Aring
2023-09-18 14:15 ` Miquel Raynal
2023-09-18 23:01 ` Alexander Aring
2023-09-19 7:14 ` Miquel Raynal
2023-09-01 17:04 ` [PATCH wpan-next v2 03/11] ieee802154: Add support for user association requests Miquel Raynal
2023-09-01 17:04 ` [PATCH wpan-next v2 04/11] mac802154: Handle associating Miquel Raynal
2023-09-16 15:36 ` Stefan Schmidt
2023-09-01 17:04 ` [PATCH wpan-next v2 05/11] ieee802154: Add support for user disassociation requests Miquel Raynal
2023-09-01 17:04 ` [PATCH wpan-next v2 06/11] mac802154: Handle disassociations Miquel Raynal
2023-09-01 17:04 ` [PATCH wpan-next v2 07/11] mac802154: Handle association requests from peers Miquel Raynal
2023-09-16 15:36 ` Stefan Schmidt
2023-09-18 7:36 ` Miquel Raynal [this message]
2023-09-01 17:04 ` [PATCH wpan-next v2 08/11] ieee802154: Add support for limiting the number of associated devices Miquel Raynal
2023-09-01 17:04 ` [PATCH wpan-next v2 09/11] mac802154: Follow " Miquel Raynal
2023-09-01 17:05 ` [PATCH wpan-next v2 10/11] mac802154: Handle disassociation notifications from peers Miquel Raynal
2023-09-01 17:05 ` [PATCH wpan-next v2 11/11] ieee802154: Give the user the association list Miquel Raynal
2023-09-16 15:36 ` Stefan Schmidt
2023-09-18 7:08 ` Miquel Raynal
2023-09-18 15:41 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918093659.6488891a@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=david.girault@qorvo.com \
--cc=edumazet@google.com \
--cc=frederic.blain@qorvo.com \
--cc=guilhem.imberton@qorvo.com \
--cc=kuba@kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@ni.fr.eu.org \
--cc=pabeni@redhat.com \
--cc=romuald.despres@qorvo.com \
--cc=stefan@datenfreihafen.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).