From: Jakub Kicinski <kuba@kernel.org>
To: Joel Becker <jlbec@evilplan.org>
Cc: Breno Leitao <leitao@debian.org>,
davem@davemloft.net, pabeni@redhat.com,
Eric Dumazet <edumazet@google.com>,
hch@lst.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
horms@kernel.org
Subject: Re: [PATCH net-next v3 2/4] netconsole: Initialize configfs_item for default targets
Date: Tue, 10 Oct 2023 18:10:13 -0700 [thread overview]
Message-ID: <20231010181013.67187de2@kernel.org> (raw)
In-Reply-To: <ZSWlppHwravDLyZN@google.com>
On Tue, 10 Oct 2023 12:27:34 -0700 Joel Becker wrote:
> > +#define NETCONSOLE_PARAM_TARGET_NAME "cmdline"
>
> Perhaps `NETCONSOLE_PARAM_TARGET_PREFIX` is better. Makes it clear this
> is not the whole name.
FWIW I had the same thought when looking at v2.
Didn't wanna nit-pick but if there's two of us...
--
pw-bot: cr
next prev parent reply other threads:[~2023-10-11 1:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 9:37 [PATCH net-next v3 0/4] net: netconsole: configfs entries for boot target Breno Leitao
2023-10-10 9:37 ` [PATCH net-next v3 1/4] netconsole: move init/cleanup functions lower Breno Leitao
2023-10-10 9:37 ` [PATCH net-next v3 2/4] netconsole: Initialize configfs_item for default targets Breno Leitao
2023-10-10 19:27 ` Joel Becker
2023-10-11 1:10 ` Jakub Kicinski [this message]
2023-10-11 12:38 ` Breno Leitao
2023-10-10 9:37 ` [PATCH net-next v3 3/4] netconsole: Attach cmdline target to dynamic target Breno Leitao
2023-10-10 9:37 ` [PATCH net-next v3 4/4] Documentation: netconsole: add support for cmdline targets Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010181013.67187de2@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=horms@kernel.org \
--cc=jlbec@evilplan.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).