From: Conor Dooley <conor@kernel.org>
To: Ante Knezic <ante.knezic@helmholz.de>
Cc: UNGLinuxDriver@microchip.com, andrew@lunn.ch,
conor+dt@kernel.org, davem@davemloft.net,
devicetree@vger.kernel.org, edumazet@google.com,
f.fainelli@gmail.com, krzysztof.kozlowski+dt@linaro.org,
kuba@kernel.org, linux-kernel@vger.kernel.org, marex@denx.de,
netdev@vger.kernel.org, olteanv@gmail.com, pabeni@redhat.com,
robh+dt@kernel.org, woojung.huh@microchip.com
Subject: Re: [PATCH net-next 2/2] dt-bindings: net: microchip,ksz: document microchip,rmii-clk-internal
Date: Wed, 11 Oct 2023 14:39:10 +0100 [thread overview]
Message-ID: <20231011-brittle-frantic-d39ec3dd23f9@spud> (raw)
In-Reply-To: <20231011132600.26297-1-ante.knezic@helmholz.de>
[-- Attachment #1: Type: text/plain, Size: 1983 bytes --]
On Wed, Oct 11, 2023 at 03:26:00PM +0200, Ante Knezic wrote:
> On Tue, 10 Oct 2023 16:25:55 +0100, Conor Dooley wrote:
> > On Tue, Oct 10, 2023 at 03:18:54PM +0200, Ante Knezic wrote:
> > > Add documentation for selecting reference rmii clock on KSZ88X3 devices
> > >
> > > Signed-off-by: Ante Knezic <ante.knezic@helmholz.de>
> > > ---
> > > Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > index e51be1ac0362..3df5d2e72dba 100644
> > > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > @@ -49,6 +49,12 @@ properties:
> > > Set if the output SYNCLKO clock should be disabled. Do not mix with
> > > microchip,synclko-125.
> > >
> > > + microchip,rmii-clk-internal:
> > > + $ref: /schemas/types.yaml#/definitions/flag
> > > + description:
> > > + Set if the RMII reference clock should be provided internally.
> >
> > > Applies only
> > > + to KSZ88X3 devices.
> >
> > This should be enforced by the schema, the example schema in the docs
> > should show you how to do this.
>
> I am guessing you are refering to limiting the property to ksz88x3 devices?
> Something like:
>
> if:
> properties:
> compatible:
> enum:
> - microchip,ksz8863
> - microchip,ksz8873
> then:
> properties:
> microchip,rmii-clk-internal:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> Set if the RMII reference clock is provided internally. Otherwise
> reference clock should be provided externally.
Not quite. The definition of the property should be outside the if/then,
but one should be used to allow/disallow the property.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-10-11 13:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 13:18 [PATCH net-next 0/2] net: dsa: microchip: enable setting rmii reference Ante Knezic
2023-10-10 13:18 ` [PATCH net-next 1/2] net:dsa:microchip: add property to select internal RMII reference clock Ante Knezic
2023-10-10 13:18 ` [PATCH net-next 2/2] dt-bindings: net: microchip,ksz: document microchip,rmii-clk-internal Ante Knezic
2023-10-10 13:25 ` Andrew Lunn
2023-10-10 13:41 ` Ante Knezic
2023-10-10 13:57 ` Andrew Lunn
2023-10-11 13:32 ` Ante Knezic
2023-10-10 15:25 ` Conor Dooley
2023-10-11 13:26 ` Ante Knezic
2023-10-11 13:39 ` Conor Dooley [this message]
2023-10-12 15:18 [PATCH net-next v2 " Conor Dooley
2023-10-16 7:53 ` [PATCH net-next " Ante Knezic
2023-10-17 8:00 ` Conor Dooley
2023-10-17 12:59 ` Andrew Lunn
2023-10-17 13:39 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231011-brittle-frantic-d39ec3dd23f9@spud \
--to=conor@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=ante.knezic@helmholz.de \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).