netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev-maintainers <edumazet@google.com>,
	kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net,
	netdev <netdev@vger.kernel.org>,
	stable@vger.kernel.org,
	Tim Menninger <tmenninger@purestorage.com>
Subject: Re: [PATCH net v1] net: dsa: mv88e6xxx: Make unsupported C45 reads return 0xffff
Date: Mon, 22 Jan 2024 14:52:02 +0200	[thread overview]
Message-ID: <20240122125202.yfyxz2flwpum3v22@skbuf> (raw)
In-Reply-To: <20240122122921.sxdkiu6udgxbs247@skbuf>

On Mon, Jan 22, 2024 at 02:29:21PM +0200, Vladimir Oltean wrote:
> On Mon, Jan 22, 2024 at 02:24:57PM +0200, Vladimir Oltean wrote:
> > > Fixes: 1a136ca2e089 ("net: mdio: scan bus based on bus capabilities for C22 and C45")
> > > Fixes: da099a7fb13d ("net: phy: Remove probe_capabilities")
> 
> Also: commit da099a7fb13d ("net: phy: Remove probe_capabilities") is not
> a functional change, so I don't see why it should be blamed? I suppose
> 'git bisect' would find 1a136ca2e089 ("net: mdio: scan bus based on bus
> capabilities for C22 and C45")?

One reason why this patch is not better than Tim's is because it does
not tell phylib straight away that there are no C45 capabilities on the
bus. It lets phylib scan the bus for all addresses, which yes, is not as
slow because no actual MDIO access is performed, but is also not as fast
as simply omitting the c45 ops altogether. I think it would be good to
state what would there be to lose if we just went for Tim's approach.

  reply	other threads:[~2024-01-22 12:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-20 19:21 [PATCH net v1] net: dsa: mv88e6xxx: Make unsupported C45 reads return 0xffff Andrew Lunn
2024-01-22 12:24 ` Vladimir Oltean
2024-01-22 12:29   ` Vladimir Oltean
2024-01-22 12:52     ` Vladimir Oltean [this message]
2024-01-22 13:39   ` Andrew Lunn
2024-01-22 20:44     ` Tim Menninger
2024-01-22 23:01       ` Andrew Lunn
2024-01-23 15:27         ` Tim Menninger
2024-01-23 22:59           ` Andrew Lunn
2024-01-24 15:59             ` Tim Menninger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240122125202.yfyxz2flwpum3v22@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=tmenninger@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).