From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 net-next 05/14] af_unix: Detect Strongly Connected Components.
Date: Sat, 24 Feb 2024 16:34:30 -0800 [thread overview]
Message-ID: <20240224163430.05595eb0@kernel.org> (raw)
In-Reply-To: <20240223214003.17369-6-kuniyu@amazon.com>
On Fri, 23 Feb 2024 13:39:54 -0800 Kuniyuki Iwashima wrote:
> + list_for_each_entry(edge, &vertex->edges, vertex_entry) {
> + struct unix_vertex *next_vertex = edge->successor->vertex;
> +
> + if (!next_vertex)
> + continue;
> +
> + if (next_vertex->index == UNIX_VERTEX_INDEX_UNVISITED) {
> + list_add(&edge->stack_entry, &edge_stack);
> +
> + vertex = next_vertex;
> + goto next_vertex;
> +prev_vertex:
> + next_vertex = vertex;
> +
> + edge = list_first_entry(&edge_stack, typeof(*edge), stack_entry);
> + list_del_init(&edge->stack_entry);
> +
> + vertex = edge->predecessor->vertex;
> +
> + vertex->lowlink = min(vertex->lowlink, next_vertex->lowlink);
> + } else if (edge->successor->vertex->on_stack) {
> + vertex->lowlink = min(vertex->lowlink, next_vertex->index);
> + }
> + }
> +
> + if (vertex->index == vertex->lowlink) {
> + struct list_head scc;
> +
> + __list_cut_position(&scc, &vertex_stack, &vertex->scc_entry);
> +
> + list_for_each_entry_reverse(vertex, &scc, scc_entry) {
> + list_move_tail(&vertex->entry, &unix_visited_vertices);
> +
> + vertex->on_stack = false;
> + }
> +
> + list_del(&scc);
> + }
> +
> + if (!list_empty(&edge_stack))
> + goto prev_vertex;
coccicheck says:
net/unix/garbage.c:406:17-23: ERROR: invalid reference to the index variable of the iterator on line 425
this code looks way to complicated to untangle on a quick weekend scan,
so please LMK if this is a false positive, I'll hide the patches from
patchwork for now ;)
next prev parent reply other threads:[~2024-02-25 0:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 21:39 [PATCH v3 net-next 00/14] af_unix: Rework GC Kuniyuki Iwashima
2024-02-23 21:39 ` [PATCH v3 net-next 01/14] af_unix: Allocate struct unix_vertex for each inflight AF_UNIX fd Kuniyuki Iwashima
2024-02-23 21:39 ` [PATCH v3 net-next 02/14] af_unix: Allocate struct unix_edge " Kuniyuki Iwashima
2024-02-23 21:39 ` [PATCH v3 net-next 03/14] af_unix: Link struct unix_edge when queuing skb Kuniyuki Iwashima
2024-02-23 21:39 ` [PATCH v3 net-next 04/14] af_unix: Bulk update unix_tot_inflight/unix_inflight " Kuniyuki Iwashima
2024-02-27 10:47 ` Paolo Abeni
2024-02-28 2:34 ` Kuniyuki Iwashima
2024-02-28 7:46 ` Paolo Abeni
2024-02-23 21:39 ` [PATCH v3 net-next 05/14] af_unix: Detect Strongly Connected Components Kuniyuki Iwashima
2024-02-25 0:34 ` Jakub Kicinski [this message]
2024-02-26 19:07 ` Kuniyuki Iwashima
2024-02-27 11:02 ` Paolo Abeni
2024-02-28 2:49 ` Kuniyuki Iwashima
2024-02-23 21:39 ` [PATCH v3 net-next 06/14] af_unix: Save listener for embryo socket Kuniyuki Iwashima
2024-02-23 21:39 ` [PATCH v3 net-next 07/14] af_unix: Fix up unix_edge.successor " Kuniyuki Iwashima
2024-02-23 21:39 ` [PATCH v3 net-next 08/14] af_unix: Save O(n) setup of Tarjan's algo Kuniyuki Iwashima
2024-02-23 21:39 ` [PATCH v3 net-next 09/14] af_unix: Skip GC if no cycle exists Kuniyuki Iwashima
2024-02-23 21:39 ` [PATCH v3 net-next 10/14] af_unix: Avoid Tarjan's algorithm if unnecessary Kuniyuki Iwashima
2024-02-23 21:40 ` [PATCH v3 net-next 11/14] af_unix: Assign a unique index to SCC Kuniyuki Iwashima
2024-02-27 11:19 ` Paolo Abeni
2024-02-28 3:05 ` Kuniyuki Iwashima
2024-02-28 7:49 ` Paolo Abeni
2024-02-28 16:25 ` Kuniyuki Iwashima
2024-02-28 17:51 ` Paolo Abeni
2024-02-23 21:40 ` [PATCH v3 net-next 12/14] af_unix: Detect dead SCC Kuniyuki Iwashima
2024-02-27 11:25 ` Paolo Abeni
2024-02-28 3:14 ` Kuniyuki Iwashima
2024-02-23 21:40 ` [PATCH v3 net-next 13/14] af_unix: Replace garbage collection algorithm Kuniyuki Iwashima
2024-02-27 11:36 ` Paolo Abeni
2024-02-28 3:32 ` Kuniyuki Iwashima
2024-02-28 8:08 ` Paolo Abeni
2024-02-28 16:29 ` Kuniyuki Iwashima
2024-02-23 21:40 ` [PATCH v3 net-next 14/14] selftest: af_unix: Test GC for SCM_RIGHTS Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240224163430.05595eb0@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).