From: kernel test robot <lkp@intel.com>
To: Pawel Dembicki <paweldembicki@gmail.com>, netdev@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, linus.walleij@linaro.org,
Pawel Dembicki <paweldembicki@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 06/16] net: dsa: vsc73xx: add port_stp_state_set function
Date: Fri, 1 Mar 2024 19:35:51 +0800 [thread overview]
Message-ID: <202403011918.VO71zUCH-lkp@intel.com> (raw)
In-Reply-To: <20240223210049.3197486-7-paweldembicki@gmail.com>
Hi Pawel,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Pawel-Dembicki/net-dsa-vsc73xx-use-read_poll_timeout-instead-delay-loop/20240224-050950
base: net-next/main
patch link: https://lore.kernel.org/r/20240223210049.3197486-7-paweldembicki%40gmail.com
patch subject: [PATCH net-next v5 06/16] net: dsa: vsc73xx: add port_stp_state_set function
config: x86_64-randconfig-161-20240301 (https://download.01.org/0day-ci/archive/20240301/202403011918.VO71zUCH-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403011918.VO71zUCH-lkp@intel.com/
smatch warnings:
drivers/net/dsa/vitesse-vsc73xx-core.c:1054 vsc73xx_refresh_fwd_map() warn: inconsistent indenting
vim +1054 drivers/net/dsa/vitesse-vsc73xx-core.c
1031
1032 static void vsc73xx_refresh_fwd_map(struct dsa_switch *ds, int port, u8 state)
1033 {
1034 struct dsa_port *other_dp, *dp = dsa_to_port(ds, port);
1035 struct vsc73xx *vsc = ds->priv;
1036 u16 mask;
1037
1038 if (state != BR_STATE_FORWARDING) {
1039 /* Ports that aren't in the forwarding state must not
1040 * forward packets anywhere.
1041 */
1042 vsc73xx_update_bits(vsc, VSC73XX_BLOCK_ANALYZER, 0,
1043 VSC73XX_SRCMASKS + port,
1044 VSC73XX_SRCMASKS_PORTS_MASK, 0);
1045
1046 dsa_switch_for_each_available_port(other_dp, ds) {
1047 if (other_dp == dp)
1048 continue;
1049 vsc73xx_update_bits(vsc, VSC73XX_BLOCK_ANALYZER, 0,
1050 VSC73XX_SRCMASKS + other_dp->index,
1051 BIT(port), 0);
1052 }
1053
> 1054 return;
1055 }
1056
1057 /* Forwarding ports must forward to the CPU and to other ports
1058 * in the same bridge
1059 */
1060 vsc73xx_update_bits(vsc, VSC73XX_BLOCK_ANALYZER, 0,
1061 VSC73XX_SRCMASKS + CPU_PORT, BIT(port), BIT(port));
1062
1063 mask = BIT(CPU_PORT);
1064
1065 if (dp->bridge) {
1066 dsa_switch_for_each_user_port(other_dp, ds) {
1067 if (other_dp->bridge == dp->bridge &&
1068 other_dp->index != port &&
1069 other_dp->stp_state == BR_STATE_FORWARDING) {
1070 int other_port = other_dp->index;
1071
1072 mask |= BIT(other_port);
1073 vsc73xx_update_bits(vsc, VSC73XX_BLOCK_ANALYZER,
1074 0,
1075 VSC73XX_SRCMASKS +
1076 other_port,
1077 BIT(port), BIT(port));
1078 }
1079 }
1080 }
1081
1082 vsc73xx_update_bits(vsc, VSC73XX_BLOCK_ANALYZER, 0,
1083 VSC73XX_SRCMASKS + port,
1084 VSC73XX_SRCMASKS_PORTS_MASK, mask);
1085 }
1086
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-03-01 11:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 21:00 [PATCH net-next v5 00/16] net: dsa: vsc73xx: Make vsc73xx usable Pawel Dembicki
2024-02-23 21:00 ` [PATCH net-next v5 01/16] net: dsa: vsc73xx: use read_poll_timeout instead delay loop Pawel Dembicki
2024-02-23 21:00 ` [PATCH net-next v5 02/16] net: dsa: vsc73xx: convert to PHYLINK Pawel Dembicki
2024-02-23 21:00 ` [PATCH net-next v5 03/16] net: dsa: vsc73xx: use macros for rgmii recognition Pawel Dembicki
2024-02-23 21:00 ` [PATCH net-next v5 04/16] net: dsa: vsc73xx: Add define for max num of ports Pawel Dembicki
2024-02-23 22:50 ` Linus Walleij
2024-02-23 21:00 ` [PATCH net-next v5 05/16] net: dsa: vsc73xx: add structure descriptions Pawel Dembicki
2024-02-23 21:00 ` [PATCH net-next v5 06/16] net: dsa: vsc73xx: add port_stp_state_set function Pawel Dembicki
2024-02-27 19:27 ` Simon Horman
2024-03-01 11:35 ` kernel test robot [this message]
2024-02-23 21:00 ` [PATCH net-next v5 07/16] net: dsa: vsc73xx: Add vlan filtering Pawel Dembicki
2024-02-23 21:00 ` [PATCH net-next v5 08/16] net: dsa: tag_sja1105: absorb logic for not overwriting precise info into dsa_8021q_rcv() Pawel Dembicki
2024-02-23 21:00 ` [PATCH net-next v5 09/16] net: dsa: tag_sja1105: absorb entire sja1105_vlan_rcv() " Pawel Dembicki
2024-02-23 21:00 ` [PATCH net-next v5 10/16] net: dsa: tag_sja1105: prefer precise source port info on SJA1110 too Pawel Dembicki
2024-02-23 21:00 ` [PATCH net-next v5 11/16] net: dsa: tag_sja1105: refactor skb->dev assignment to dsa_tag_8021q_find_user() Pawel Dembicki
2024-02-23 21:00 ` [PATCH net-next v5 12/16] net: dsa: vsc73xx: introduce tag 8021q for vsc73xx Pawel Dembicki
2024-02-27 2:54 ` Jakub Kicinski
2024-02-23 21:00 ` [PATCH net-next v5 13/16] net: dsa: vsc73xx: Implement the tag_8021q VLAN operations Pawel Dembicki
2024-02-23 21:00 ` [PATCH net-next v5 14/16] net: dsa: Define max num of bridges in tag8021q implementation Pawel Dembicki
2024-02-23 21:00 ` [PATCH net-next v5 15/16] net: dsa: vsc73xx: Add bridge support Pawel Dembicki
2024-02-23 21:00 ` [PATCH net-next v5 16/16] net: dsa: vsc73xx: start treating the BR_LEARNING flag Pawel Dembicki
2024-02-27 19:30 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403011918.VO71zUCH-lkp@intel.com \
--to=lkp@intel.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=paweldembicki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).