netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ignat Korchagin <ignat@cloudflare.com>
To: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kernel-team@cloudflare.com, Ignat Korchagin <ignat@cloudflare.com>
Subject: [PATCH net v3 0/2] net: veth: ability to toggle GRO and XDP independently
Date: Wed, 13 Mar 2024 19:37:57 +0100	[thread overview]
Message-ID: <20240313183759.87923-1-ignat@cloudflare.com> (raw)

It is rather confusing that GRO is automatically enabled, when an XDP program
is attached to a veth interface. Moreover, it is not possible to disable GRO
on a veth, if an XDP program is attached (which might be desirable in some use
cases).

Make GRO and XDP independent for a veth interface. udpgro_fwd

Changes in v3:
  * adjust udpgro_fwd selftest to explicitly enable GRO on veth interfaces,
    where it expects GRO to happen

Changes in v2:
  * add Fixes reference to commit description
  * fix commit message spelling

Ignat Korchagin (2):
  net: veth: do not manipulate GRO when using XDP
  selftests: net: veth: test the ability to independently manipulate GRO
    and XDP

 drivers/net/veth.c                        | 18 -----------------
 tools/testing/selftests/net/udpgro_fwd.sh |  4 ++++
 tools/testing/selftests/net/veth.sh       | 24 ++++++++++++++++++++---
 3 files changed, 25 insertions(+), 21 deletions(-)

-- 
2.39.2


             reply	other threads:[~2024-03-13 18:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 18:37 Ignat Korchagin [this message]
2024-03-13 18:37 ` [PATCH net v3 1/2] net: veth: do not manipulate GRO when using XDP Ignat Korchagin
2024-03-13 18:37 ` [PATCH net v3 2/2] selftests: net: veth: test the ability to independently manipulate GRO and XDP Ignat Korchagin
2024-03-18 12:30 ` [PATCH net v3 0/2] net: veth: ability to toggle GRO and XDP independently patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240313183759.87923-1-ignat@cloudflare.com \
    --to=ignat@cloudflare.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kernel-team@cloudflare.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).