Re: [PATCH RFC v2 6/6] tools: ynl: ethtool.py: Output timestamping statistics from tsinfo-get operation

From: Jakub Kicinski <kuba@kernel.org>
To: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Cc: ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
	alexandre.torgue@foss.st.com, andrew@lunn.ch, corbet@lwn.net,
	davem@davemloft.net, dtatulea@nvidia.com, edumazet@google.com,
	gal@nvidia.com, hkallweit1@gmail.com, jacob.e.keller@intel.com,
	jiri@resnulli.us, joabreu@synopsys.com, justinstitt@google.com,
	kory.maincent@bootlin.com, leon@kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	liuhangbin@gmail.com, maxime.chevallier@bootlin.com,
	netdev@vger.kernel.org, pabeni@redhat.com,
	paul.greenwalt@intel.com, przemyslaw.kitszel@intel.com,
	rdunlap@infradead.org, richardcochran@gmail.com,
	saeed@kernel.org, tariqt@nvidia.com, vadim.fedorenko@linux.dev,
	vladimir.oltean@nxp.com, wojciech.drewek@intel.com
Subject: Re: [PATCH RFC v2 6/6] tools: ynl: ethtool.py: Output timestamping statistics from tsinfo-get operation
Date: Thu, 14 Mar 2024 11:05:53 -0700	[thread overview]
Message-ID: <20240314110553.1c5310c9@kernel.org> (raw)
In-Reply-To: <87ttl9fhyd.fsf@nvidia.com>

On Wed, 13 Mar 2024 23:07:22 -0700 Rahul Rameshbabu wrote:
> What's your expectation for how the request structure would look like? I
> have tried the following.
> 
>   if args.show_time_stamping:
>       req = {
>         'header': {
>           'flags': 'stats',
>         },
>       }
> 
>   if args.show_time_stamping:
>       req = {
>         'header': {
>           'flags': {
>              'stats': True,
>           },
>         },
>       }
> 
> I tried looking through the lib/ynl.py code, but I did not understand
> how the 'flags' type was specifically handled.

Rebased on latest net-next?

I used this:

./tools/net/ynl/cli.py \
	--spec Documentation/netlink/specs/ethtool.yaml \
	--do fec-get --json '{"header":{"dev-index": 2, "flags": "stats"}}'