From: Leon Romanovsky <leon@kernel.org>
To: Antony Antony <antony.antony@secunet.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, devel@linux-ipsec.org,
Eyal Birger <eyal.birger@gmail.com>
Subject: Re: [PATCH ipsec-next v4] xfrm: Add Direction to the SA in or out
Date: Thu, 14 Mar 2024 14:27:50 +0200 [thread overview]
Message-ID: <20240314122750.GD12921@unreal> (raw)
In-Reply-To: <515e7c749459afdd61af95bd40ce0d5f2173fc30.1710363570.git.antony.antony@secunet.com>
On Wed, Mar 13, 2024 at 10:04:51PM +0100, Antony Antony wrote:
> This patch introduces the 'dir' attribute, 'in' or 'out', to the
> xfrm_state, SA, enhancing usability by delineating the scope of values
> based on direction. An input SA will now exclusively encompass values
> pertinent to input, effectively segregating them from output-related
> values. This change aims to streamline the configuration process and
> improve the overall clarity of SA attributes.
>
> Signed-off-by: Antony Antony <antony.antony@secunet.com>
> ---
> v3->v4:
> - improve HW OFFLOAD DIR check check other direction
>
> v2->v3:
> - delete redundant XFRM_SA_DIR_USET
> - use u8 for "dir"
> - fix HW OFFLOAD DIR check
>
> v1->v2:
> - use .strict_start_type in struct nla_policy xfrma_policy
> - delete redundant XFRM_SA_DIR_MAX enum
> ---
> include/net/xfrm.h | 1 +
> include/uapi/linux/xfrm.h | 6 +++++
> net/xfrm/xfrm_compat.c | 7 ++++--
> net/xfrm/xfrm_device.c | 6 +++++
> net/xfrm/xfrm_state.c | 1 +
> net/xfrm/xfrm_user.c | 46 +++++++++++++++++++++++++++++++++++----
> 6 files changed, 61 insertions(+), 6 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2024-03-14 12:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 21:04 [PATCH ipsec-next v4] xfrm: Add Direction to the SA in or out Antony Antony
2024-03-14 12:27 ` Leon Romanovsky [this message]
2024-03-14 14:28 ` [devel-ipsec] " Nicolas Dichtel
2024-03-17 22:34 ` Antony Antony
2024-03-22 8:20 ` Nicolas Dichtel
2024-04-04 8:38 ` Antony Antony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240314122750.GD12921@unreal \
--to=leon@kernel.org \
--cc=antony.antony@secunet.com \
--cc=devel@linux-ipsec.org \
--cc=eyal.birger@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).