From: Felix Fietkau <nbd@nbd.name>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC] netfilter: nf_tables: ignore -EOPNOTSUPP on flowtable device offload setup
Date: Fri, 1 Sep 2023 12:30:37 +0200 [thread overview]
Message-ID: <2575f329-7d95-46f8-ab88-2bcdf8b87d66@nbd.name> (raw)
In-Reply-To: <ZPGjVl7jmLhMhgBP@calendula>
On 01.09.23 10:39, Pablo Neira Ayuso wrote:
> Hi Felix,
>
> On Thu, Aug 31, 2023 at 10:14:20PM +0200, Felix Fietkau wrote:
>> On many embedded devices, it is common to configure flowtable offloading for
>> a mix of different devices, some of which have hardware offload support and
>> some of which don't.
>> The current code limits the ability of user space to properly set up such a
>> configuration by only allowing adding devices with hardware offload support to
>> a offload-enabled flowtable.
>> Given that offload-enabled flowtables also imply fallback to pure software
>> offloading, this limitation makes little sense.
>> Fix it by not bailing out when the offload setup returns -EOPNOTSUPP
>
> Would you send a v2 to untoggle the offload flag when listing the
> ruleset if EOPNOTSUPP is reported? Thus, the user knows that no
> hardware offload is being used.
Wouldn't that mess up further updates to the flowtable? From what I can
tell, when updating a flow table, changing its offload flag is not
supported.
- Felix
next prev parent reply other threads:[~2023-09-01 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 20:14 [RFC] netfilter: nf_tables: ignore -EOPNOTSUPP on flowtable device offload setup Felix Fietkau
2023-09-01 8:39 ` Pablo Neira Ayuso
2023-09-01 10:30 ` Felix Fietkau [this message]
2023-09-01 12:29 ` Pablo Neira Ayuso
2023-09-01 12:47 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2575f329-7d95-46f8-ab88-2bcdf8b87d66@nbd.name \
--to=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).