netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com,
	jakub.kicinski@netronome.com
Subject: Re: [patch net-next rfc 02/15] netdevsim: create devlink instance per netdevsim instance
Date: Mon, 15 Apr 2019 09:07:04 -0600	[thread overview]
Message-ID: <2e024c38-0368-1dae-4be5-07b34d596a58@gmail.com> (raw)
In-Reply-To: <20190415054104.GD24144@nanopsycho.orion>

On 4/14/19 11:41 PM, Jiri Pirko wrote:
> Mon, Apr 15, 2019 at 04:24:24AM CEST, dsahern@gmail.com wrote:
>> On 4/13/19 10:20 AM, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@mellanox.com>
>>>
>>> Currently there is one devlink instance created per network namespace.
>>> That is quite odd considering the fact that devlink instance should
>>> represent an ASIC. The following patches are going to move the devlink
>>> instance even more down to a bus device, but until then, have one
>>> devlink instance per netdevsim instance. Struct nsim_devlink is
>>> introduced to hold fib setting.
>>>
>>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>>> ---
>>>  drivers/net/netdevsim/devlink.c   | 179 +++++++++++-------------------
>>>  drivers/net/netdevsim/fib.c       | 103 +++++++----------
>>>  drivers/net/netdevsim/netdev.c    |  27 ++---
>>>  drivers/net/netdevsim/netdevsim.h |  18 +--
>>>  4 files changed, 125 insertions(+), 202 deletions(-)
>>
>> you are making a lot of changes to how fib events are handled and not
>> explaining what you are doing.
> 
> They are handled in the exact same way. This is just about devlink
> instance. Will add that to description.
> 


Data is currently stored as a net_generic. You are changing that. The
changelog should state that.

  reply	other threads:[~2019-04-15 15:07 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-13 16:20 [patch net-next rfc 00/15] netdevsim: impement proper device model Jiri Pirko
2019-04-13 16:20 ` [patch net-next rfc 01/15] netdevsim: move device registration on bus to be done earlier in init Jiri Pirko
2019-04-13 16:20 ` [patch net-next rfc 02/15] netdevsim: create devlink instance per netdevsim instance Jiri Pirko
2019-04-15  2:24   ` David Ahern
2019-04-15  5:41     ` Jiri Pirko
2019-04-15 15:07       ` David Ahern [this message]
2019-04-15 15:39         ` Jiri Pirko
2019-04-13 16:21 ` [patch net-next rfc 03/15] netdevsim: rename devlink.c to dev.c to contain per-dev(asic) items Jiri Pirko
2019-04-13 16:21 ` [patch net-next rfc 04/15] netdevsim: put netdevsim bus code into separate file Jiri Pirko
2019-04-14 20:27   ` David Miller
2019-04-15  5:40     ` Jiri Pirko
2019-04-13 16:21 ` [patch net-next rfc 05/15] netdevsim: move device registration and related code to bus.c Jiri Pirko
2019-04-13 16:21 ` [patch net-next rfc 06/15] netdevsim: add stub netdevsim driver implementation Jiri Pirko
2019-04-13 16:21 ` [patch net-next rfc 07/15] netdevsim: use ida for bus device ids Jiri Pirko
2019-04-13 16:21 ` [patch net-next rfc 08/15] netdevsim: add bus attributes to add new and delete devices Jiri Pirko
2019-04-13 16:21 ` [patch net-next rfc 09/15] netdevsim: rename dev_init/exit() functions and make them independent on ns Jiri Pirko
2019-04-13 16:21 ` [patch net-next rfc 10/15] netdevsim: merge sdev into dev Jiri Pirko
2019-04-15 20:49   ` Jakub Kicinski
2019-04-16  8:49     ` Jiri Pirko
2019-04-13 16:21 ` [patch net-next rfc 11/15] netdevsim: generate random switch id instead of using dev id Jiri Pirko
2019-04-13 16:21 ` [patch net-next rfc 12/15] netdevsim: change debugfs tree topology Jiri Pirko
2019-04-13 16:21 ` [patch net-next rfc 13/15] netdevsim: implement dev probe/remove skeleton with port initialization Jiri Pirko
2019-04-13 16:21 ` [patch net-next rfc 14/15] netdevsim: move netdev creation/destruction to dev probe Jiri Pirko
2019-04-13 16:21 ` [patch net-next rfc 15/15] netdevsim: implement ndo_get_devlink_port Jiri Pirko
2019-04-15 19:27 ` [patch net-next rfc 00/15] netdevsim: impement proper device model Jakub Kicinski
2019-04-16  8:53   ` Jiri Pirko
2019-04-16 17:58     ` Jakub Kicinski
2019-04-16  8:59   ` Jiri Pirko
2019-04-16 18:04     ` Jakub Kicinski
2019-04-18  7:22       ` Jiri Pirko
2019-04-18 17:07         ` Jakub Kicinski
2019-04-19  5:25           ` Jiri Pirko
2019-04-19 21:00             ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e024c38-0368-1dae-4be5-07b34d596a58@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=jiri@resnulli.us \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).