From: Shannon Nelson <snelson@pensando.io>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: mkubecek@suse.cz, thomas.lendacky@amd.com, benve@cisco.com,
_govind@gmx.com, pkaustub@cisco.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, joabreu@synopsys.com,
yisen.zhuang@huawei.com, salil.mehta@huawei.com,
jeffrey.t.kirsher@intel.com, jacob.e.keller@intel.com,
alexander.h.duyck@linux.intel.com, michael.chan@broadcom.com,
saeedm@mellanox.com, leon@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 06/12] ionic: let core reject the unsupported coalescing parameters
Date: Tue, 3 Mar 2020 20:22:50 -0800 [thread overview]
Message-ID: <313a02b6-cdfe-0322-2e16-67f1901b6724@pensando.io> (raw)
In-Reply-To: <20200304035501.628139-7-kuba@kernel.org>
On 3/3/20 7:54 PM, Jakub Kicinski wrote:
> Set ethtool_ops->coalesce_types to let the core reject
> unsupported coalescing parameters.
>
> This driver correctly rejects all unsupported parameters.
> No functional changes.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Thanks!
Acked-by: Shannon Nelson <snelson@pensando.io>
> ---
> .../ethernet/pensando/ionic/ionic_ethtool.c | 23 +------------------
> 1 file changed, 1 insertion(+), 22 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> index f778fff034f5..83ea35715533 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> @@ -412,28 +412,6 @@ static int ionic_set_coalesce(struct net_device *netdev,
> unsigned int i;
> u32 coal;
>
> - if (coalesce->rx_max_coalesced_frames ||
> - coalesce->rx_coalesce_usecs_irq ||
> - coalesce->rx_max_coalesced_frames_irq ||
> - coalesce->tx_max_coalesced_frames ||
> - coalesce->tx_coalesce_usecs_irq ||
> - coalesce->tx_max_coalesced_frames_irq ||
> - coalesce->stats_block_coalesce_usecs ||
> - coalesce->use_adaptive_rx_coalesce ||
> - coalesce->use_adaptive_tx_coalesce ||
> - coalesce->pkt_rate_low ||
> - coalesce->rx_coalesce_usecs_low ||
> - coalesce->rx_max_coalesced_frames_low ||
> - coalesce->tx_coalesce_usecs_low ||
> - coalesce->tx_max_coalesced_frames_low ||
> - coalesce->pkt_rate_high ||
> - coalesce->rx_coalesce_usecs_high ||
> - coalesce->rx_max_coalesced_frames_high ||
> - coalesce->tx_coalesce_usecs_high ||
> - coalesce->tx_max_coalesced_frames_high ||
> - coalesce->rate_sample_interval)
> - return -EINVAL;
> -
> ident = &lif->ionic->ident;
> if (ident->dev.intr_coal_div == 0) {
> netdev_warn(netdev, "bad HW value in dev.intr_coal_div = %d\n",
> @@ -784,6 +762,7 @@ static int ionic_nway_reset(struct net_device *netdev)
> }
>
> static const struct ethtool_ops ionic_ethtool_ops = {
> + .coalesce_types = ETHTOOL_COALESCE_USECS,
> .get_drvinfo = ionic_get_drvinfo,
> .get_regs_len = ionic_get_regs_len,
> .get_regs = ionic_get_regs,
next prev parent reply other threads:[~2020-03-04 4:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 3:54 [PATCH net-next 00/12] ethtool: consolidate parameter checking for irq coalescing Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 01/12] ethtool: add infrastructure for centralized checking of coalescing parameters Jakub Kicinski
2020-03-04 14:54 ` Andrew Lunn
2020-03-04 15:19 ` Michal Kubecek
2020-03-04 15:22 ` Andrew Lunn
2020-03-04 18:11 ` Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 02/12] xgbe: let core reject the unsupported " Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 03/12] enic: " Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 04/12] stmmac: " Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 05/12] nfp: " Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 06/12] ionic: " Jakub Kicinski
2020-03-04 4:22 ` Shannon Nelson [this message]
2020-03-04 3:54 ` [PATCH net-next 07/12] hisilicon: " Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 08/12] ice: " Jakub Kicinski
2020-03-04 4:24 ` Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 09/12] bnxt: reject unsupported coalescing params Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 10/12] mlx5: " Jakub Kicinski
2020-03-04 3:55 ` [PATCH net-next 11/12] e1000e: " Jakub Kicinski
2020-03-04 3:55 ` [PATCH net-next 12/12] virtio_net: " Jakub Kicinski
2020-03-04 4:07 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=313a02b6-cdfe-0322-2e16-67f1901b6724@pensando.io \
--to=snelson@pensando.io \
--cc=_govind@gmx.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=alexandre.torgue@st.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=pkaustub@cisco.com \
--cc=saeedm@mellanox.com \
--cc=salil.mehta@huawei.com \
--cc=thomas.lendacky@amd.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).