netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeedm@mellanox.com>
To: Gavi Teitz <gavi@mellanox.com>,
	"wenxu@ucloud.cn" <wenxu@ucloud.cn>,
	Roi Dayan <roid@mellanox.com>, Vlad Buslov <vladbu@mellanox.com>,
	Jianbo Liu <jianbol@mellanox.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net/mlx5e: restrict the real_dev of vlan device is the same as uplink device
Date: Fri, 17 May 2019 20:30:59 +0000	[thread overview]
Message-ID: <32affe9e97f26ff1c7b5993255a6783533fe6bff.camel@mellanox.com> (raw)
In-Reply-To: <1557912345-14649-1-git-send-email-wenxu@ucloud.cn>

On Wed, 2019-05-15 at 17:25 +0800, wenxu@ucloud.cn wrote:
> From: wenxu <wenxu@ucloud.cn>
> 
> When register indr block for vlan device, it should check the
> real_dev
> of vlan device is same as uplink device. Or it will set offload rule
> to mlx5e which will never hit.
> 

I would improve the commit message, it is not really clear to me what
is going on here.

Anyway Roi and team, can you please provide feedback ..

> Signed-off-by: wenxu <wenxu@ucloud.cn>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> index 91e24f1..a39fdac 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> @@ -796,7 +796,7 @@ static int mlx5e_nic_rep_netdevice_event(struct
> notifier_block *nb,
>  	struct net_device *netdev = netdev_notifier_info_to_dev(ptr);
>  
>  	if (!mlx5e_tc_tun_device_to_offload(priv, netdev) &&
> -	    !is_vlan_dev(netdev))
> +	    !(is_vlan_dev(netdev) && vlan_dev_real_dev(netdev) ==
> rpriv->netdev))
>  		return NOTIFY_OK;
>  
>  	switch (event) {

  reply	other threads:[~2019-05-17 20:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15  9:25 [PATCH] net/mlx5e: restrict the real_dev of vlan device is the same as uplink device wenxu
2019-05-17 20:30 ` Saeed Mahameed [this message]
2019-05-18  3:10   ` wenxu
2019-05-19  6:49     ` Roi Dayan
2019-05-20 21:23       ` Saeed Mahameed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32affe9e97f26ff1c7b5993255a6783533fe6bff.camel@mellanox.com \
    --to=saeedm@mellanox.com \
    --cc=gavi@mellanox.com \
    --cc=jianbol@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=roid@mellanox.com \
    --cc=vladbu@mellanox.com \
    --cc=wenxu@ucloud.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).