From: Matt Corallo <linux-wired-list@bluematt.me>
To: Nick Lowe <nick.lowe@gmail.com>, netdev@vger.kernel.org
Cc: anthony.l.nguyen@intel.com, kuba@kernel.org,
jesse.brandeburg@intel.com, intel-wired-lan@lists.osuosl.org,
davem@davemloft.net
Subject: Re: [PATCH net] igb: Enable RSS for Intel I211 Ethernet Controller
Date: Sun, 31 Jan 2021 18:17:11 -0500 [thread overview]
Message-ID: <379d4ef3-02e5-f08a-1b04-21848e11a365@bluematt.me> (raw)
In-Reply-To: <20201221222502.1706-1-nick.lowe@gmail.com>
Given this fixes a major (albeit ancient) performance regression, is it not a candidate for backport? It landed on
Tony's dev-queue branch with a Fixes tag but no stable CC.
Thanks,
Matt
On 12/21/20 5:25 PM, Nick Lowe wrote:
> The Intel I211 Ethernet Controller supports 2 Receive Side Scaling (RSS) queues.
> It should not be excluded from having this feature enabled.
>
> Via commit c883de9fd787b6f49bf825f3de3601aeb78a7114
> E1000_MRQC_ENABLE_RSS_4Q was renamed to E1000_MRQC_ENABLE_RSS_MQ to
> indicate that this is a generic bit flag to enable queues and not
> a flag that is specific to devices that support 4 queues
>
> The bit flag enables 2, 4 or 8 queues appropriately depending on the part.
>
> Tested with a multicore CPU and frames were then distributed as expected.
>
> This issue appears to have been introduced because of confusion caused
> by the prior name.
>
> Signed-off-by: Nick Lowe <nick.lowe@gmail.com>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index 03f78fdb0dcd..87ac1d3e25cb 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -4482,8 +4482,7 @@ static void igb_setup_mrqc(struct igb_adapter *adapter)
> else
> mrqc |= E1000_MRQC_ENABLE_VMDQ;
> } else {
> - if (hw->mac.type != e1000_i211)
> - mrqc |= E1000_MRQC_ENABLE_RSS_MQ;
> + mrqc |= E1000_MRQC_ENABLE_RSS_MQ;
> }
> igb_vmm_control(adapter);
>
>
next prev parent reply other threads:[~2021-01-31 23:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 22:25 [PATCH net] igb: Enable RSS for Intel I211 Ethernet Controller Nick Lowe
2021-01-31 23:17 ` Matt Corallo [this message]
2021-02-01 16:47 ` Jakub Kicinski
2021-02-01 18:32 ` Nguyen, Anthony L
2021-02-01 19:45 ` Jakub Kicinski
2021-02-01 20:06 ` Nick Lowe
2021-02-01 20:21 ` Matt Corallo
2021-02-01 20:23 ` Nick Lowe
2021-02-01 20:33 ` Jakub Kicinski
2021-05-03 12:32 ` Nick Lowe
2021-05-03 18:30 ` Jakub Kicinski
2021-05-03 19:53 ` Stable inclusion request - " Nick Lowe
2021-05-04 4:43 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2020-12-21 19:15 [PATCH net] " Nick Lowe
2020-12-21 22:11 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=379d4ef3-02e5-f08a-1b04-21848e11a365@bluematt.me \
--to=linux-wired-list@bluematt.me \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick.lowe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).