From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Vedang Patel <vedang.patel@intel.com>, netdev@vger.kernel.org
Cc: jeffrey.t.kirsher@intel.com, davem@davemloft.net,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
intel-wired-lan@lists.osuosl.org, vinicius.gomes@intel.com,
l@dorileo.org
Subject: Re: [PATCH net-next v3 2/6] etf: Add skip_sock_check
Date: Tue, 18 Jun 2019 12:28:35 +0300 [thread overview]
Message-ID: <3b9b74f4-526e-143e-21a9-ffd841b26bcb@cogentembedded.com> (raw)
In-Reply-To: <1560799870-18956-3-git-send-email-vedang.patel@intel.com>
Hello!
On 17.06.2019 22:31, Vedang Patel wrote:
> Currently, etf expects a socket with SO_TXTIME option set for each packet
> it encounters. So, it will drop all other packets. But, in the future
> commits we are planning to add functionality which where tstamp value will
> be set by another qdisc. Also, some packets which are generated from within
> the kernel (e.g. ICMP packets) do not have any socket associated with them.
>
> So, this commit adds support for skip_sock_check. When this option is set,
> etf will skip checking for a socket and other associated options for all
> skbs.
>
> Signed-off-by: Vedang Patel <vedang.patel@intel.com>
> ---
> include/uapi/linux/pkt_sched.h | 1 +
> net/sched/sch_etf.c | 10 ++++++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h
> index 8b2f993cbb77..69fc52e4d6bd 100644
> --- a/include/uapi/linux/pkt_sched.h
> +++ b/include/uapi/linux/pkt_sched.h
> @@ -990,6 +990,7 @@ struct tc_etf_qopt {
> __u32 flags;
> #define TC_ETF_DEADLINE_MODE_ON BIT(0)
> #define TC_ETF_OFFLOAD_ON BIT(1)
> +#define TC_ETF_SKIP_SOCK_CHECK BIT(2)
Please indent with a tab like above, not 2 spaces.
[...]
MBR, Sergei
next prev parent reply other threads:[~2019-06-18 9:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 19:31 [PATCH net-next v3 0/6] net/sched: Add txtime-assist support for taprio Vedang Patel
2019-06-17 19:31 ` [PATCH net-next v3 1/6] igb: clear out tstamp after sending the packet Vedang Patel
2019-06-21 1:50 ` [Intel-wired-lan] " Brown, Aaron F
2019-06-17 19:31 ` [PATCH net-next v3 2/6] etf: Add skip_sock_check Vedang Patel
2019-06-18 9:28 ` Sergei Shtylyov [this message]
2019-06-19 16:55 ` Patel, Vedang
2019-06-17 19:31 ` [PATCH net-next v3 3/6] taprio: calculate cycle_time when schedule is installed Vedang Patel
2019-06-17 19:31 ` [PATCH net-next v3 4/6] taprio: Add support for txtime-assist mode Vedang Patel
2019-06-17 23:22 ` David Miller
2019-06-19 16:54 ` Patel, Vedang
2019-06-17 19:31 ` [PATCH net-next v3 5/6] taprio: make clock reference conversions easier Vedang Patel
2019-06-17 23:23 ` David Miller
2019-06-17 19:31 ` [PATCH net-next v3 6/6] taprio: Adjust timestamps for TCP packets Vedang Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b9b74f4-526e-143e-21a9-ffd841b26bcb@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=l@dorileo.org \
--cc=netdev@vger.kernel.org \
--cc=vedang.patel@intel.com \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).