From: Raju Rangoju <Raju.Rangoju@amd.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Tom Lendacky <thomas.lendacky@amd.com>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] amd-xgbe: fix mismatched prototype
Date: Thu, 16 Feb 2023 08:55:06 +0530 [thread overview]
Message-ID: <4912931a-67c9-8f9c-bb08-611eeb3d6c03@amd.com> (raw)
In-Reply-To: <0441fa72-a07a-8c3e-717d-563f03fd2ea1@amd.com>
On 2/7/2023 12:24 PM, Shyam Sundar S K wrote:
>
>
> On 2/7/2023 11:58 AM, Jakub Kicinski wrote:
>> On Fri, 3 Feb 2023 13:15:36 +0100 Arnd Bergmann wrote:
>>> The forward declaration was introduced with a prototype that does
>>> not match the function definition:
>>>
>>> drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c:2166:13: error: conflicting types for 'xgbe_phy_perform_ratechange' due to enum/integer mismatch; have 'void(struct xgbe_prv_data *, enum xgbe_mb_cmd, enum xgbe_mb_subcmd)' [-Werror=enum-int-mismatch]
>>> 2166 | static void xgbe_phy_perform_ratechange(struct xgbe_prv_data *pdata,
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c:391:13: note: previous declaration of 'xgbe_phy_perform_ratechange' with type 'void(struct xgbe_prv_data *, unsigned int, unsigned int)'
>>> 391 | static void xgbe_phy_perform_ratechange(struct xgbe_prv_data *pdata,
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Thanks for the fix. What's the compiler / extra flags you're using?
>> Doesn't pop up on our setups..
>>
>
> Yes please. Even this does not pop on our build systems too. Would like
> to know those extra compiler flags.
Hi Arnd,
Gentle reminder!
Please share the compiler details / additional flags used to reproduce
this warning.
Thanks,
Raju
>
> Thanks,
> Shyam
next prev parent reply other threads:[~2023-02-16 3:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 12:15 [PATCH] amd-xgbe: fix mismatched prototype Arnd Bergmann
2023-02-04 13:18 ` Simon Horman
2023-02-06 4:09 ` Shyam Sundar S K
2023-02-07 6:28 ` Jakub Kicinski
2023-02-07 6:54 ` Shyam Sundar S K
2023-02-16 3:25 ` Raju Rangoju [this message]
2023-02-07 6:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4912931a-67c9-8f9c-bb08-611eeb3d6c03@amd.com \
--to=raju.rangoju@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).